-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add move annotation on objects for cluster move operation #8322
🌱 Add move annotation on objects for cluster move operation #8322
Conversation
Welcome @pkbhowmick! |
Hi @pkbhowmick. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pkbhowmick Thanks for opening the PR. I will take a look at this tomorrow. |
/ok-to-test |
/test pull-cluster-api-e2e-full-main |
82dbf03
to
9163716
Compare
Hi @fabriziopandini |
@fabriziopandini |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit.
LGTM otherwise.
88347e3
to
461079f
Compare
/retest |
@pkbhowmick: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
461079f
to
de84cd7
Compare
/retest |
we are near the finish line, one last rebase (it will probably fix markdown links too)... |
de84cd7
to
a044e4a
Compare
Signed-off-by: Pulak Kanti Bhowmick <pkbhowmick007@gmail.com>
a044e4a
to
4ac5f3d
Compare
Yes, rebase done! |
/lgtm |
LGTM label has been added. Git tree hash: 1a82ff8af88d3e8d2f007469d5974a3c935680a7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add move annotation on objects those are going to be deleted for cluster move operation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8109