Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Temporarily disable IPAM provider e2e test #423

Merged
merged 1 commit into from
Feb 14, 2024
Merged

🌱 Temporarily disable IPAM provider e2e test #423

merged 1 commit into from
Feb 14, 2024

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Feb 14, 2024

What this PR does / why we need it:

Release v0.1.0 doesn't contain all required CRDs. Despite the fact CAPI operator is able to deploy the provider, it fails with errors like

2024-02-14T17:16:19.922069142Z stderr F W0214 17:16:19.921859       1 reflector.go:539] k8s.io/client-go@v0.29.0/tools/cache/reflector.go:229: failed to list *v1beta1.IPAddressClaim: the server could not find the requested resource (get ipaddressclaims.ipam.cluster.x-k8s.io)
2024-02-14T17:16:19.922109534Z stderr F E0214 17:16:19.921908       1 reflector.go:147] k8s.io/client-go@v0.29.0/tools/cache/reflector.go:229: Failed to watch *v1beta1.IPAddressClaim: failed to list *v1beta1.IPAddressClaim: the server could not find the requested resource (get ipaddressclaims.ipam.cluster.x-k8s.io)
2024-02-14T17:16:32.300340334Z stderr F W0214 17:16:32.300157       1 reflector.go:539] k8s.io/client-go@v0.29.0/tools/cache/reflector.go:229: failed to list *v1beta1.IPAddress: the server could not find the requested resource (get ipaddresses.ipam.cluster.x-k8s.io)
2024-02-14T17:16:32.300390059Z stderr F E0214 17:16:32.300213       1 reflector.go:147] k8s.io/client-go@v0.29.0/tools/cache/reflector.go:229: Failed to watch *v1beta1.IPAddress: failed to list *v1beta1.IPAddress: the server could not find the requested resource (get ipaddresses.ipam.cluster.x-k8s.io)

We have to temporarily disable IPAM e2e tests until the issue is fixed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2024
@Fedosin Fedosin changed the title test: temporarily disable IPAM provider e2e test 🌱 Temporarily disable IPAM provider e2e test Feb 14, 2024
Danil-Grigorev
Danil-Grigorev approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22bd3209967c88ab6aa62de08761820c6d19ddac

Fedosin
Fedosin commented Feb 14, 2024
View reviewed changes
Copy link
Contributor Author

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
Danil-Grigorev
Danil-Grigorev reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6c4684 into kubernetes-sigs:main Feb 14, 2024
13 of 14 checks passed
@furkatgofurov7 furkatgofurov7 mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@Danil-Grigorev Danil-Grigorev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fedosin @k8s-ci-robot @Danil-Grigorev