-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 feat(rbac): use real ServiceAccount instead of default #519
🐛 feat(rbac): use real ServiceAccount instead of default #519
Conversation
Welcome @cwrau! |
Hi @cwrau. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
88c8e7d
to
168724c
Compare
168724c
to
7b21533
Compare
I don't know how I would make the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
7b21533
to
8289cd2
Compare
8289cd2
to
a4db00b
Compare
Heyho, is there something I can do to help this get merged? 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -15,6 +15,8 @@ spec: | |||
labels: | |||
control-plane: controller-manager | |||
spec: | |||
serviceAccountName: manager | |||
automountServiceAccountToken: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: is this set to false and best practice, when the default SA is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the question correctly, yes, it's best-practice to set this to false when not using a custom serviceAccount to prevent the accidental usage of the default serviceAccount
In general it's best-practice to not use the default serviceAccount anyways
/lgtm |
LGTM label has been added. Git tree hash: f5f14b2b0c0f7450c4f4b41b5755d685ac50892c
|
Heyho, is there a timeline when this will be released? |
@cwrau since this is breaking change and can't be released with patch release (and in fact it was not backported). I just checked the changelog since last minor v0.11 release and it is quite small for cutting a minor release. How urgent this change for you, can we give some more time for new minor release before cutting it? |
Why is this a breaking change? 🤔
But if we assume that this is a breaking change, why would you ever want to release this as a minor version instead of a breaking one?! 😮
Is it a problem to release frequently with small changes? 🤔 But it's not urgent right now, we're using flux pathes to rectify this in the meantime |
That is because the PR was labelled with
Breaking changes are usually accepted and released as part of the minor releases and not the patch. I am not sure what do you mean as "breaking one" in this context. |
Ah, @Fedosin changed the title at some point, maybe he can chime in why?
Oh, sorry, typo 😅 So this project is not following semver? 😕 |
Well, it does follow semver in a way similar to how CAPI does https://cluster-api.sigs.k8s.io/contributing?highlight=release#breaking-changes, but in semVer world breaking changes should land in major release, that I agree. Also, by looking at this PR again, IMO it is not a breaking change but rather a bug fix considering what it tries to solve |
Closes #518