Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opentelemetry tracing #2178

Open
richardcase opened this issue Dec 29, 2020 · 19 comments
Open

Add Opentelemetry tracing #2178

richardcase opened this issue Dec 29, 2020 · 19 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@richardcase
Copy link
Member

/kind feature
/help

Describe the solution you'd like
I'd like to be able to see tracing of the various controllers using opentelemetry. This will enable us to see how many and how long reconcile loops, AWS API calls etc take which will be very helpful for issue investigation.

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot
Copy link
Contributor

@richardcase:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind feature
/help

Describe the solution you'd like
I'd like to be able to see tracing of the various controllers using opentelemetry. This will enable us to see how many and how long reconcile loops, AWS API calls etc take which will be very helpful for issue investigation.

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 29, 2020
@randomvariable
Copy link
Member

We should probably help take this to completion kubernetes-sigs/controller-runtime#1211

@randomvariable randomvariable added this to the v0.7.0 milestone Jan 5, 2021
@richardcase
Copy link
Member Author

I agree @randomvariable .

We could also start to add OpenTelemetry spans like they have done in CAPZ and then when kubernetes-sigs/controller-runtime#1211 is agreed and implemeted we'd need to make sure that we use the existing parent spans from the context when we create our spans.

@randomvariable randomvariable modified the milestones: v0.7.0, v0.7.x Mar 11, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 9, 2021
@richardcase
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 9, 2021
@randomvariable randomvariable modified the milestones: v0.7.x, Backlog Nov 8, 2021
@randomvariable
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 8, 2021
@bisakhmondal
Copy link

Hi guys, I am Bisakh, wish to improve/add the observability of this module through tracing and metrics-based monitoring with Prometheus as part of GSoC 2022. I am new to this project and want to get myself involved into the core infrastructure. Could you please guide me here by passing on some of your workloads so that I can learn by doing different things?
Eagerly waiting for your reply. Thanks : )

@sedefsavas
Copy link
Contributor

Hi @bisakhmondal, welcome to the community.

You can start with some issues with good-first-issue label to get a grip on the project.
Here is the getting started doc: https://cluster-api-aws.sigs.k8s.io/getting-started.html
Feel free to reach us at #cluster-api-aws slack channel for questions.

We haven't started working on the design yet.
Applications for GSoC will start in April AFAIK, and it is not certain that our project is accepted yet.

@bisakhmondal
Copy link

Hi @sedefsavas, thanks for the detailed reply. I'll start working on the issues then.

We haven't started working on the design yet.

No issues, I can also help there. Feel free to include me in your design meeting.

Applications for GSoC will start in April AFAIK, and it is not certain that our project is accepted yet.

Yes, the first week of April. I have a huge interest in cloud-native stuffs and recently I am working with monitoring tools and solutions so I want to explore more. Just curious, what do you mean by the selection here? I see the project is listed on cncf page (cncf/mentoring repo ig).

@xylonx
Copy link

xylonx commented Mar 31, 2022

Hi, I am xylonx wanting to sovle the issue by introducing some observation tool like prometheus or jaeger and collecting the metrics info by opentelemetry. Actually, I want to treat it as my GSoC 2022 project. I am new in this community and hope it can encourage my cloud native knowledge and skill. I have used opentelemetry and prometheus / jaeger before, therefore I think I can solve it. Could you give me some practical advice ? Hoping for your reply :)

@richardcase
Copy link
Member Author

@rvacaru @xylonx @bisakhmondal - looks like the deadline for submitting a proposal for GSoC is 19th April. Would it be worth us having a call to go through this issue?

@richardcase
Copy link
Member Author

It would be worth having a look at the demo Bryan did in the CAPI office hours on 16th Sept 2021: https://youtu.be/aThFgrYthOc

@richardcase
Copy link
Member Author

There was an issue on CAPI as well to add this but it was closed as it went stale: kubernetes-sigs/cluster-api#3760.

Adttionally CAPZ added otel support see:

@HeyAdityaPatidar
Copy link

Hey! @sedefsavas and @richardcase, I'm Aditya, I want to work on the project for GSoC. Is it already assigned to anyone else?
Can you please acknowledge me on this project?
Can you help me with this problem?

@richardcase
Copy link
Member Author

Hi @HeyAdityaPatidar. I believe the deadline to submit a proposal for GSoC has now passed. You could try logging on to the portal to see if it still lets your submit a proposal?

@richardcase
Copy link
Member Author

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 12, 2022
@richardcase richardcase removed this from the Backlog milestone Jul 25, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2022
@Aut0R3V
Copy link

Aut0R3V commented Nov 13, 2022

@richardcase I would like to work on this issue. I went through the discussion that you guys had. Could you tell me what needs to be done for this? I would like to assign myself for this issue.

@richardcase
Copy link
Member Author

/assign Aut0R3V

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants