Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prebootstrapcommand in machinepool / managed machinepool #2771

Closed
kholisrag opened this issue Sep 15, 2021 · 19 comments
Closed

prebootstrapcommand in machinepool / managed machinepool #2771

kholisrag opened this issue Sep 15, 2021 · 19 comments
Assignees
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/feature Categorizes issue or PR as related to a new feature. kind/release-blocking Issues or PRs that need to be closed before the next release lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@kholisrag
Copy link

/kind feature

Describe the solution you'd like
a preBootstrapCommand feature like that eksctl have, maybe both in unmanaged node / managed node. its greate feature for all of us I believe

Anything else you would like to add:
for our case, we need to mount the instance store of aws ec2 instance and be able to use it in hostPath of PersistentVolume

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority labels Sep 15, 2021
@randomvariable
Copy link
Member

For EC2, you can do that already in KubeadmConfigTemplate and KubeadmControlPlane under preKubeadmCommands.

@randomvariable randomvariable added the area/provider/eks Issues or PRs related to Amazon EKS provider label Sep 15, 2021
@kholisrag
Copy link
Author

@randomvariable if we use eks and unmanaged node we can do that? can you elaborate more how to do it?

@randomvariable
Copy link
Member

Sorry, I misread this. This is indeed a missing feature.

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Oct 6, 2021
@randomvariable randomvariable added this to the v1.0.x milestone Oct 6, 2021
@richardcase
Copy link
Member

I'll pick up this as part of my work on launchtemplates as it touches that area for machine pools (managed/unmanaged):

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 8, 2021
@richardcase
Copy link
Member

Will include this along with #2854 instead of the launch templates change.

@sedefsavas sedefsavas modified the milestones: v1.0.x, v1.1.0 Nov 15, 2021
@richardcase
Copy link
Member

Moving miletone

/milestone v1.2.0

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.1.0, v1.2.0 Nov 17, 2021
@sedefsavas
Copy link
Contributor

sedefsavas commented Dec 15, 2021

We may need to take this into account during Launch Templates design: #3024

@sedefsavas
Copy link
Contributor

Since this is not only relevant to MachinePools, we need to come up with a generic solution for all Machines as @richardcase pointed.

This is blocking enabling clusterctl upgrade tests, which will help to catch conversion related issues, so adding release-blocking tag.

@sedefsavas sedefsavas added the kind/release-blocking Issues or PRs that need to be closed before the next release label Dec 16, 2021
@cnmcavoy
Copy link
Contributor

cnmcavoy commented Mar 9, 2022

Interested in this functionality and trying to understand where it is at...given that #2854 was closed in preference to #2965 and neither addressed the missing bootstrapping features for this issue.

Is working on this issue blocked on #3024 being merged? What work remains before a PR could be submitted to add this functionality?

@richardcase
Copy link
Member

@cnmcavoy - its being some separately. Theres only a small amount of work to do...will get it finished in the next few days.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Jun 8, 2022
@richardcase
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 8, 2022
@richardcase
Copy link
Member

/milestone v1.6.0

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.5.0, v1.6.0 Jul 25, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Oct 23, 2022

I believe this will be handled by #3757

@richardcase
Copy link
Member

richardcase commented Nov 1, 2022

I believe this will be handled by #3757

Yes it will. My change was stopped in favour of #3757

@richardcase richardcase removed this from the v1.6.0 milestone Nov 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/feature Categorizes issue or PR as related to a new feature. kind/release-blocking Issues or PRs that need to be closed before the next release lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
8 participants