Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make e2e v1alpha3 to v1alpha4 upgrade actually work #2805

Closed
randomvariable opened this issue Sep 27, 2021 · 5 comments
Closed

Make e2e v1alpha3 to v1alpha4 upgrade actually work #2805

randomvariable opened this issue Sep 27, 2021 · 5 comments
Assignees
@randomvariable
Labels
area/testing Issues or PRs related to testing kind/bug Categorizes issue or PR as related to a bug. kind/release-blocking Issues or PRs that need to be closed before the next release lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@randomvariable
Copy link
Member

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
kubernetes-sigs/cluster-api#5327 (comment) should have been surfaced in CAPA e2e, but we weren't actually running the test, so we now need to turn it on.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Need to make the following additional changes:

  • Set credentials correctly
  • Modify manifests such that webhooks run in a separate container in the pod, so that issues with the controller don't break the CRD

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority labels Sep 27, 2021
@randomvariable
Copy link
Member Author

/priority critical-urgent
/kind release-blocking

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/release-blocking Issues or PRs that need to be closed before the next release and removed needs-priority labels Sep 27, 2021
@randomvariable
Copy link
Member Author

/area testing

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Sep 27, 2021
@randomvariable
Copy link
Member Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 27, 2021
@randomvariable
Copy link
Member Author

/close

in favour of
#2793

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closing this issue.

In response to this:

/close

in favour of
#2793

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randomvariable randomvariable

Labels
area/testing Issues or PRs related to testing kind/bug Categorizes issue or PR as related to a bug. kind/release-blocking Issues or PRs that need to be closed before the next release lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randomvariable @k8s-ci-robot