Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of hack/ensure-golangci-lint.sh #4366

Closed
richardcase opened this issue Jun 29, 2023 · 1 comment · Fixed by #4367
Closed

Remove usage of hack/ensure-golangci-lint.sh #4366

richardcase opened this issue Jun 29, 2023 · 1 comment · Fixed by #4367
Assignees
@richardcase
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@richardcase
Copy link
Member

/kind bug
/priority critical-urgent
/triage accepted

We need to remove the usage of hack/ensure-golangci-lint.sh as its copied from a repo with GPL license.

We can use kubernetes-sigs/cluster-api#8933 for reference.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 29, 2023
@richardcase
Copy link
Member Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jun 29, 2023
@richardcase richardcase mentioned this issue Jun 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove usage of script to install golangci-lint richardcase/cluster-api-provider-aws
2 participants
@richardcase @k8s-ci-robot