🌱 Build golangci-lint locally #8933
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e6133a3938f93d4add2d141b0f06d2697cb79bd5
|
|
/lgtm Not sure if we previously had problems with local building. Based on #4700 it sounds like it was mostly about dependencies which is not an issue anymore with the way we build today |
|
We don't have anymore hack/tools/go.mod issues that existed before, it is simpler and it stays in sync we what we use in CI |
|
/approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.4 |
|
@fabriziopandini: new pull request created: #8935 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/area devtools |
What this PR does / why we need it:
This PR switch to building golangci-lint locally, so we can leverage the same mechanism used by other tools and drop the script for downloading the right version.
Note. We are picking the version from .github/workflows/golangci-lint.yml, so we ensure the version used by CI and the version used by make are always in sync.