Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add webhook port flag #1176

Merged
merged 1 commit into from
Oct 9, 2019
Merged

✨ Add webhook port flag #1176

merged 1 commit into from
Oct 9, 2019

Conversation

luigi-riefolo
Copy link
Contributor

What this PR does / why we need it:
Add webhook port flag (default 8443)

Which issue(s) this PR fixes :
Fixes #1120

@k8s-ci-robot
Copy link
Contributor

Welcome @luigi-riefolo!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @luigi-riefolo. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2019
@luigi-riefolo
Copy link
Contributor Author

/assign @luxas

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 6, 2019
vincepri
vincepri approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2019
@detiber
Copy link
Member

detiber commented Oct 7, 2019

This PR should probably also update the manager_webhook_patch.yaml here as well: https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/config/default/manager_webhook_patch.yaml#L12

@vincepri vincepri changed the title ✨ add webhook port flag ✨ Add webhook port flag Oct 7, 2019
@luigi-riefolo
Copy link
Contributor Author

@detiber done

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2019
@detiber
Copy link
Member

detiber commented Oct 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2019
@ncdc
Copy link
Contributor

ncdc commented Oct 7, 2019

@luigi-riefolo could you please squash this down to 1 commit? Thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2019
@luigi-riefolo luigi-riefolo force-pushed the feature/webhook-port-flag branch from d52f672 to 63edee5 Compare October 8, 2019 19:29
@luigi-riefolo
Copy link
Contributor Author

@ncdc done

@detiber
Copy link
Member

detiber commented Oct 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2019
ncdc
ncdc reviewed Oct 8, 2019
View reviewed changes
main.go Outdated Show resolved Hide resolved
@tahsinrahman
Copy link
Contributor

kubebuilder 2.0.1 switched to default port 9443 for webhook server. should we also use 9443?
kubernetes-sigs/kubebuilder#983

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@luigi-riefolo luigi-riefolo force-pushed the feature/webhook-port-flag branch from a88ae49 to 9bc7bc6 Compare October 9, 2019 11:34
@detiber
Copy link
Member

detiber commented Oct 9, 2019

kubebuilder 2.0.1 switched to default port 9443 for webhook server. should we also use 9443?
kubernetes-sigs/kubebuilder#983

Thanks for catching that @tahsinrahman, I think we should likely try to stick with kubebuilder defaults here.

@luigi-riefolo luigi-riefolo force-pushed the feature/webhook-port-flag branch from 9bc7bc6 to be25807 Compare October 9, 2019 14:58
@luigi-riefolo
Copy link
Contributor Author

@tahsinrahman @detiber set to 9443

@ncdc ncdc added this to the v0.4.x milestone Oct 9, 2019
@ncdc
Copy link
Contributor

ncdc commented Oct 9, 2019

/lgtm
@detiber over to you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@detiber
Copy link
Member

detiber commented Oct 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, luigi-riefolo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7447919 into kubernetes-sigs:master Oct 9, 2019
@luigi-riefolo luigi-riefolo deleted the feature/webhook-port-flag branch October 11, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@vincepri vincepri vincepri approved these changes

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@rudoi rudoi Awaiting requested review from rudoi

Assignees

@ncdc ncdc

@detiber detiber

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.x
Development

Successfully merging this pull request may close these issues.

Make the webhook server port configurable via flag
7 participants
@luigi-riefolo @k8s-ci-robot @detiber @ncdc @tahsinrahman @vincepri @luxas