Skip deleting 'control-plane.cluster-api-provider-aws.sigs.k8s.io' if it does not exist in the e2e setup #3795
Conversation
… it does not exist in the e2e setup
k8s-ci-robot
added
kind/bug
|
Hi @cnmcavoy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -454,8 +454,7 @@ func deleteResourcesInCloudFormation(prov client.ConfigProvider, t *cfn_bootstra | |||
| tayp := val.AWSCloudFormationType() | |||
| if tayp == configservice.ResourceTypeAwsIamRole { | |||
| role := val.(*cfn_iam.Role) | |||
| _, err := iamSvc.DeleteRole(&iam.DeleteRoleInput{RoleName: aws.String(role.RoleName)}) | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| _, _ = iamSvc.DeleteRole(&iam.DeleteRoleInput{RoleName: aws.String(role.RoleName)}) | |||
There was a problem hiding this comment.
I see few places(like detaching role policies) that the errors are checked.
Is there a specific scenario you came up where the tests are failing?
There was a problem hiding this comment.
Ok i missed the slack thread. Read it now.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/test pull-cluster-api-provider-aws-e2e-blocking |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
Does not explicitly error when a IAM role deletion fails in
deleteResourcesInCloudFormatione2e logic. All of the other error handling indeleteResourcesInCloudFormationis suppressed, it's unclear why this error was checked and no others.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3794
Special notes for your reviewer:
Checklist: