Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the quickstart guide needs update for external cloud provider #4301

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix: the quickstart guide needs update for external cloud provider #4301

merged 2 commits into from
Jun 1, 2023

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented May 31, 2023 •
edited by Ankitasw
Loading

What type of PR is this?
/kind bug
What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4299

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

The quick start guide is generated using this template and needs to use external provider.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels May 31, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2023
@xmudrii
Copy link
Member

xmudrii commented May 31, 2023

/test pull-cluster-api-provider-aws-test

@Skarlso
Copy link
Contributor Author

Skarlso commented May 31, 2023

Uh, I'm not sure about all of this. There is something not okay. There are templates in our e2e folder that use aws provider and still work. Yet this thing doesn't. I'm not sure what's up.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2023
Ankitasw
Ankitasw reviewed May 31, 2023
View reviewed changes
...ture-aws/withclusterclass/e2e_test_templates/cluster-template-external-vpc-clusterclass.yaml Outdated
@@ -0,0 +1,1078 @@
apiVersion: cluster.x-k8s.io/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not required in templates, as we are not running this test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove. Thanks.

@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase
Copy link
Member

Just to test the EKS prow change:

/test pull-cluster-api-provider-aws-e2e-eks-gc

@Skarlso
Copy link
Contributor Author

Skarlso commented May 31, 2023

/test pull-cluster-api-provider-aws-e2e-eks-gc

@Ankitasw Ankitasw changed the title fix: the quickstart guid needs external provider fix: the quickstart guide needs update for external cloud provider May 31, 2023
@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023
@Ankitasw
Copy link
Member

Ankitasw commented Jun 1, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit bf08732 into kubernetes-sigs:main Jun 1, 2023
johananl added a commit to johananl/cluster-api-provider-aws that referenced this pull request Sep 26, 2023
@johananl
flatcar: Set cloud-provider kubelet flag to "external"
9542d04 
In-tree cloud provider support was removed in k8s v1.27.

See the following:

- kubernetes/kubernetes#118899
- kubernetes/kubernetes#115838
- kubernetes-sigs#4301

Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
@johananl johananl mentioned this pull request Sep 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankitasw Ankitasw Ankitasw left review comments

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@dthorsen dthorsen Awaiting requested review from dthorsen

Assignees

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QuickStart: control plane is ready but cannot initialized
5 participants
@Skarlso @xmudrii @richardcase @k8s-ci-robot @Ankitasw