-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s & cluster api dependency #4569
Conversation
assign @vincepri |
This PR is increments the k8s.io packages and their dependencies. But it also increments github.com/aws/aws-sdk-go. Can you move that to its own PR? Can sigs.k8s.io/kustomize/api also be moved it its own PR? |
sure, BTW, what does |
what do i need to do, since the conflict occurs too frequently |
ping @dlipovetsky
I reverted aws-sdk-go, but the kustomize is related to k8s version, and it is automatically need to update as well |
We normally bump the k8s/controller-runtime/capi dependencies at the same time. So bumping the k8s packages to v0.28.2 without the others isn't the process we follow. However, CAPI |
Sorry, I donot have bandwidth recently, anyone could take it over. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@richardcase ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, thanks @hzxuzhonghu.
Just some minor comments.
go.mod
Outdated
k8s.io/cli-runtime v0.27.3 | ||
k8s.io/client-go v0.27.3 | ||
k8s.io/component-base v0.27.3 | ||
k8s.io/api v0.28.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably change this to 0.28.4 now but lets do that afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/lgtm For final approval: |
/test pull-cluster-api-provider-aws-e2e |
Due to the test failures: /remove-lgtm |
/test pull-cluster-api-provider-aws-e2e |
@hzxuzhonghu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
does this mean cluster-api 1.16 is broken for aws?
|
You might have to check the controller logs to know what is wrong |
Where is the log? |
maybe related kubernetes-sigs/cluster-api#9502 I am not familiar with that, can you guide me how to fix it @richardcase @Ankitasw |
/test pull-cluster-api-provider-aws-e2e-eks Running again and then will investigate |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sigs.k8s.io/cluster-api/test v1.5.3 | ||
sigs.k8s.io/controller-runtime v0.15.1 | ||
sigs.k8s.io/kustomize/api v0.13.4 | ||
sigs.k8s.io/cluster-api v1.6.0-beta.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hzxuzhonghu Are you able to pick this up again and update to the GA v1.6.0 release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i think i met some problems #4569 (comment)
Does 1.6.0 fix it
This is superceded by #4739 /close |
@nrb: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4505
Special notes for your reviewer:
Checklist:
Release note: