Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: create vpc objects in explicitly provided availability zones #4950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ feat: create vpc objects in explicitly provided availability zones #4950

wants to merge 1 commit into from

Conversation

synthe102
Copy link
Contributor

@synthe102 synthe102 commented Apr 23, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4333, continues the work started by @Skarlso in this PR by:

  • moving de defaults for AvailabilityZoneSelection and AvailabilityZoneUsageLimit into defaulting webhooks instead of CRDs
  • adding check in validating webhooks for conflicting use of AvailabilityZoneUsageLimit and AvailabilityZoneSelection with AvailabilityZones

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Ability to specify Availability Zones from spec.network.vpc in AWSManagedControlPlane, AWSCluster and AWSClusterTemplate CRDs.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @synthe102. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2024
@synthe102 synthe102 mentioned this pull request Apr 23, 2024
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2024
@AndiDog
Copy link
Contributor

AndiDog commented Jul 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2024
AndiDog
AndiDog reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the release note to something that's readable by users (.spec.vpc) instead of developers (VPCSpec), and best use a verb to describe the change.

api/v1beta2/awscluster_webhook.go Outdated Show resolved Hide resolved
api/v1beta2/awscluster_webhook.go Outdated Show resolved Hide resolved
api/v1beta2/network_types.go Show resolved Hide resolved
api/v1beta2/network_types.go Outdated Show resolved Hide resolved
controlplane/eks/api/v1beta2/awsmanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
pkg/cloud/services/network/subnets.go Show resolved Hide resolved
@synthe102 synthe102 force-pushed the main branch 7 times, most recently from ca10c55 to 41de7ec Compare July 17, 2024 10:00
@synthe102
Copy link
Contributor Author

@AndiDog Thanks a lot for this initial review. I addressed all your comments, all the tests are OK so far.

@synthe102
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-verify

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
AndiDog
AndiDog reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor suggestions that can mostly be included directly. Looks good overall. Only a rebase is needed after those changes, so the PR is mergeable (you may just have some conflicts that go away with git rebase origin/main && make generate).

pkg/cloud/services/network/subnets.go Outdated Show resolved Hide resolved
pkg/cloud/services/network/subnets.go Outdated Show resolved Hide resolved
pkg/cloud/services/network/subnets_test.go Outdated Show resolved Hide resolved
pkg/cloud/services/network/subnets_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@synthe102
Copy link
Contributor Author

@AndiDog Thanks for the review !
PR is rebased and I added your suggestions.

@AndiDog
Copy link
Contributor

AndiDog commented Aug 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2024
@cpwc
Copy link

cpwc commented Aug 23, 2024

Hi @AndiDog anyone can take a look at this PR? Looking for another /approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndiDog AndiDog AndiDog left review comments

@faiq faiq Awaiting requested review from faiq

Assignees

@AndiDog AndiDog

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to specify Availability Zones from the VPCSpec object
4 participants
@synthe102 @k8s-ci-robot @AndiDog @cpwc