Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add natgatewayips as source for ingress rules #5005

Merged
merged 1 commit into from
Jun 20, 2024
Merged

✨ Add natgatewayips as source for ingress rules #5005

merged 1 commit into from
Jun 20, 2024

Conversation

alexander-demicev
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR will allow using nat gateway IPs as sources in ingress rules. In my setup, I need machines to be able to connect to the load balancer through a certain port and I would like the load balancer to only accept traffic for this port from my machines. From the load balancer point of view the connection is made from nat gateway IPs so the CAPA API has to have a setting for this.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add natgatewayips as source for ingress rules

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jun 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2024
@alexander-demicev alexander-demicev changed the title Add natgatewayips as source for ingress rules ✨ Add natgatewayips as source for ingress rules Jun 6, 2024
@alexander-demicev
Add natgatewayips as source for ingress rules
ce23840 
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@alexander-demicev
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@alexander-demicev
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@alexander-demicev
Copy link
Contributor Author

@nrb @damdo folks, can I get a review? all tests are passing

@nrb
Copy link
Contributor

nrb commented Jun 10, 2024

/milestone v2.6.0

@k8s-ci-robot
Copy link
Contributor

@nrb: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v2.6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nrb nrb added this to the v2.6.0 milestone Jun 10, 2024
@nrb
Copy link
Contributor

nrb commented Jun 12, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
furkatgofurov7
furkatgofurov7 reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

to give reviewers in the repo chance to take a look

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@salasberryfin
Copy link

/lgtm thanks for adding this useful feature.

damdo
damdo reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex
/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7ab0780 into kubernetes-sigs:main Jun 20, 2024
22 checks passed
@alexander-demicev alexander-demicev deleted the natgatwaysipsingress branch June 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@damdo damdo damdo left review comments

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@faiq faiq Awaiting requested review from faiq

Assignees

@damdo damdo

@furkatgofurov7 furkatgofurov7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@alexander-demicev @nrb @k8s-ci-robot @salasberryfin @damdo @furkatgofurov7