Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛: ec2/byoip: fix EIP leak when creating machine #5039

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Jun 28, 2024

  1. 🐛: ec2/byoip: fix EIP leak when creating machine

    The instance creation flow is creating by default EIP to instances even
    if the BYO IP flow is set. BYO IPv4 creates and associates the EIP to
    instance after it is created, preventing paying for additional EIP
    (amazon-provided) when creating the instance when the BYO IPv4 Pool is
    defined to be used by the machine.
    
    Furthermore, the fix provides additional checks to prevent duplicated EIP
    in the BYO IP reconciliation loop. The extra checks include running the
    EIP association many times, while the EIP is already associated, and
    failures in the log when running the EIP association prematurely - when
    the instance isn't ready, Eg ec2 in pending state.
    mtulio committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d5882fa View commit details
    Browse the repository at this point in the history