-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 subnets: use "owned" k8s tag value for managed subnets. #5051
Conversation
Hi @r4f4. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LGTM |
This bump includes the following fix: * kubernetes-sigs/cluster-api-provider-aws#5051
No regressions in the Openshift e2e tests: openshift/installer#8730
|
/ok-to-test |
Quite a major tagging change, but I agree it was incorrect to set
I'm not sure if this has an impact somewhere, except for custom user code that may rely on the values. But then again, we already had inconsistent tags and that would now be fixed:
So, if the tests pass: /lgtm |
/hold It seems I missed some unit tests. |
The "shared" value will be used for unmanaged subnets.
Weird, the test is passing locally:
/test pull-cluster-api-provider-aws-test |
/test ? |
@r4f4: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-aws-e2e pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e-blocking |
/test pull-cluster-api-provider-aws-e2e |
/hold cancel |
/test pull-cluster-api-provider-aws-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest timeout |
/retest This pass isn't strictly required, but I would love to see it not timeout. |
@nrb all the triggered tests have passed. |
@r4f4 🤦 that's what I get for only reading email. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This bump includes the following fix: * kubernetes-sigs/cluster-api-provider-aws#5051
This bump includes the following fix: * kubernetes-sigs/cluster-api-provider-aws#5051
The "shared" value will be used for unmanaged subnets.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Tag managed subnets with "kubernetes.io/cluster/: owned" tag.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5050
Special notes for your reviewer:
Checklist:
Release note: