-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Ensure Volumes and Network Interfaces are also tagged when created as part of instance creation #5057
✨ Ensure Volumes and Network Interfaces are also tagged when created as part of instance creation #5057
Conversation
Welcome @fahlmant! |
Hi @fahlmant. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update the tests so that the new behavior is also tested.
0b61305
to
a9a3633
Compare
@fiunchinho tests added |
/retest |
@fahlmant: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
a9a3633
to
7d4d4b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/test ? |
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e-eks |
1 similar comment
/test pull-cluster-api-provider-aws-e2e-eks |
@richardcase The EKS test seems to be failing due to the CF stack not creating the expected IAM roles. Any guidance on what's going wrong? |
/test pull-cluster-api-provider-aws-e2e-eks |
@fahlmant - i see it passing now. Sometimes we have flakes. If it persistently fails then it would be an issue with a specific test node and we'd need to look into that. |
Considering @fiunchinho previously did an lgtm: /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
ENIs and EBS Volumes that are created as part of instance creation are not being tagged with the tags that are applied to the instance. Since these resources are created as part of the AWS API call to create the instance itself, it follows that the same tags would be applied at creation time. AWS allows for restrictions against CreateTags as a standalone API call vs CreateTags as part of a call to the RunInstances API call. This change allows restrictions against standalone CreateTags calls against existing resources, while still allowing the creation of tags at on the resource.
Special notes for your reviewer:
Checklist:
Release note: