Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update Go version to 1.22.6 #5078

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Jul 30, 2024

What type of PR is this?

/kind support

What this PR does / why we need it:

Updates to Go 1.22 in order to account for updated Go module toolchain behaviors.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2024
@nrb
Copy link
Contributor Author

nrb commented Jul 30, 2024

/assign @damdo @richardcase

@richardcase
Copy link
Member

Should we update the go version in the other places as well?

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already included it in https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5061/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R23

But if we want to do that early that's ok too, as I see this is failing on other PRs so we might not want to wait for 5061

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@nrb
Copy link
Contributor Author

nrb commented Jul 31, 2024

Should we update the go version in the other places as well?

Will update some of these, but fwiw the go.mod can be left alone unless we're using Go 1.22-specific features.

@damdo
Copy link
Member

damdo commented Aug 7, 2024

It looks like this is now blocking other PRs as the verify job is permafailing until this merges. cc. @nrb

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
@nrb nrb changed the title 🌱 Update Go version to 1.22.5 🌱 Update Go version to 1.22.6 Aug 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2024
@nrb
Copy link
Contributor Author

nrb commented Aug 7, 2024

@damdo @richardcase Updated Go version in all the relevant places I could find. Also bumped to the latest patch release.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2024
@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 111ea90 into kubernetes-sigs:main Aug 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants