Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add cluster registry config #5132

Merged
merged 2 commits into from
Oct 16, 2024
Merged

✨ Add cluster registry config #5132

merged 2 commits into from
Oct 16, 2024

Conversation

serngawy
Copy link
Contributor

@serngawy serngawy commented Oct 2, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add the registry config to ROSA control plane API

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

 Add ROSA Control plane registry configuration.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 2, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2024
@serngawy
Copy link
Contributor Author

serngawy commented Oct 3, 2024

@nrb @muraee would you add ok-to-test

@nrb
Copy link
Contributor

nrb commented Oct 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2024
@nrb
Copy link
Contributor

nrb commented Oct 10, 2024

@serngawy Can you please update the go module files?

@serngawy serngawy force-pushed the clsReg branch 2 times, most recently from 1babc6e to 14484d8 Compare October 10, 2024 15:49
@serngawy
Add cluster registry config
83c4046 
Signed-off-by: melserngawy <melserng@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 10, 2024
@nrb
Copy link
Contributor

nrb commented Oct 11, 2024

/assign @damdo @muraee

@nrb
Copy link
Contributor

nrb commented Oct 11, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 11, 2024
@nrb nrb added this to the v2.7.0 milestone Oct 14, 2024
@serngawy
Fix mocks function updates
0f5f56f 
Signed-off-by: melserngawy <melserng@redhat.com>
damdo
damdo reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @muraee @richardcase @nrb
For approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2024
@damdo damdo requested a review from muraee October 16, 2024 07:33
@muraee
Copy link
Contributor

muraee commented Oct 16, 2024

/approve

@richardcase
Copy link
Member

I only looked at the API definitions and not the ROSA parts in other dirs.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7cc5ee3 into kubernetes-sigs:main Oct 16, 2024
19 checks passed
fad3t pushed a commit to fad3t/cluster-api-provider-aws that referenced this pull request Oct 24, 2024
@serngawy @fad3t
✨ Add cluster registry config (kubernetes-sigs#5132)
93a286d 
* Add cluster registry config

Signed-off-by: melserngawy <melserng@redhat.com>

* Fix mocks function updates

Signed-off-by: melserngawy <melserng@redhat.com>

---------

Signed-off-by: melserngawy <melserng@redhat.com>
sebltm pushed a commit to sebltm/cluster-api-provider-aws that referenced this pull request Nov 24, 2024
@serngawy @sebltm
✨ Add cluster registry config (kubernetes-sigs#5132)
b398f11 
* Add cluster registry config

Signed-off-by: melserngawy <melserng@redhat.com>

* Fix mocks function updates

Signed-off-by: melserngawy <melserng@redhat.com>

---------

Signed-off-by: melserngawy <melserng@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb left review comments

@damdo damdo damdo left review comments

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@muraee muraee Awaiting requested review from muraee

Assignees

@richardcase richardcase

@nrb nrb

@damdo damdo

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@serngawy @k8s-ci-robot @nrb @muraee @richardcase @damdo