-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ CIDR blocks for default Security Group rule "Node Port Services" #5147
base: main
Are you sure you want to change the base?
✨ CIDR blocks for default Security Group rule "Node Port Services" #5147
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @krasoffski. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
75c03a7
to
daf349d
Compare
/ok-to-test |
daf349d
to
09931bf
Compare
@AndiDog Thank you, Andreas. Looks like tests are passed. @richardcase @killianmuldoon guys, could you, please, take a look? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
There is issue #3314 which describes problem when default Security Group rule "Node Port Services" it too wide.
This PR allows to specify CIDR Blocks for Security Group rule "Node Port Services" with keeping original behavior if no CIDR Blocks are provided by attribute
AWSCluster.spec.network.NodePortIngressRuleCidrBlocks
.In our practice, we've deployed stackgres and add LB for Admin page, but security team found opened ports with this admin page, cause stackgress by default open NodePort too under the hood.
Thus allowing to specify networks from which node port services can be accessed negotiated this problem.
Which issue(s) this PR fixes:
Fixes #3314 (possible fix).
Special notes for your reviewer:
I did not add similar attribute for IPv6 CIDR blocks because there is validation that
IPv6 cannot be used with unmanaged clusters at this time.
.New unit tests for original and new behavior are added.
Added unit tests for webhook validation of correctness provided CidrBlocks.
Checklist:
Release note: