Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create certificates, admin kubeconfig, bootstrap token and discoveryhashes using kubeadm #136

Merged
merged 8 commits into from
Mar 17, 2019
Merged

Create certificates, admin kubeconfig, bootstrap token and discoveryhashes using kubeadm #136

merged 8 commits into from
Mar 17, 2019

Conversation

awesomenix
Copy link
Contributor

@awesomenix awesomenix commented Mar 13, 2019 •
edited
Loading

What this PR does / why we need it:

Currently we manually generate certificates and supporting configuration, instead use kubeadm standard tooling for generating all the base configuration required to bootstrap kubernetes nodes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Usage of upstream kubeadm tool for generation of prerequisites

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @awesomenix. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. area/provider/azure Issues or PRs related to azure provider labels Mar 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2019
@awesomenix
Copy link
Contributor Author

/assign @tariq1890 @justaugustus

tariq1890
tariq1890 reviewed Mar 14, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Mar 14, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Mar 14, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
@justaugustus
Copy link
Member

/hold
(For my review)

I'm at a conference this week, so my availability is going to be limited.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2019
@justaugustus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2019
@awesomenix
Generate certificates using kubeadm instead of manual operations righ…
795be7b 
…t now, this consolidates efforts into upstream, any bug fixes, updates are consumed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2019
@awesomenix
Copy link
Contributor Author

Thanks @tariq1890 i have removed all the overrides, great suggestion (its much simpler now). Fixed all the lint and test issues, could you please take another look.

tariq1890
tariq1890 reviewed Mar 14, 2019
View reviewed changes
Gopkg.lock Show resolved Hide resolved
tariq1890
tariq1890 reviewed Mar 14, 2019
View reviewed changes
Gopkg.lock
revision = "05914d821849570fba9eacfb29466f2d8d3cd229"
version = "kubernetes-1.13.1"
revision = "74b699b93c15473932b89e3d1818ba8282f3b5ab"
version = "kubernetes-1.13.3"
Copy link
Contributor

@tariq1890 tariq1890 Mar 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda ambivalent towards locking into a Kubernetes dependency without pinning it. Will defer to @justaugustus on that.

If this is agreed upon, Can we change to kubernetes-1.13.4 ?

@justaugustus
Copy link
Member

/cc @detiber @chuckha @vincepri @randomvariable
(for opinions)

juan-lee
juan-lee reviewed Mar 15, 2019
View reviewed changes
Copy link
Contributor

@juan-lee juan-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
(For my review)

I'm at a conference this week, so my availability is going to be limited.

@justaugustus anything of particular concern in this PR that we can address?

pkg/apis/azureprovider/v1alpha1/azureclusterproviderconfig_types.go Outdated Show resolved Hide resolved
detiber
detiber reviewed Mar 15, 2019
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this change looks good, I'd consider moving the two fields I mentioned to status rather than Spec.

Gopkg.toml Show resolved Hide resolved
pkg/apis/azureprovider/v1alpha1/azureclusterproviderconfig_types.go Outdated Show resolved Hide resolved
pkg/apis/azureprovider/v1alpha1/azureclusterproviderconfig_types.go Outdated Show resolved Hide resolved
@detiber
Copy link
Member

detiber commented Mar 15, 2019

@vincepri we should definitely sync on these changes with the AWS provider.

@awesomenix
Copy link
Contributor Author

@detiber @justaugustus @juan-lee @tariq1890 Thanks for helpful comments, I have updated the PR to incorporate all the comments, would appreciate another look at PR

@juan-lee juan-lee mentioned this pull request Mar 16, 2019
Closed
6 tasks
@awesomenix awesomenix mentioned this pull request Mar 16, 2019
Closed
6 tasks
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awesomenix, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2019
@justaugustus
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4b67c07 into kubernetes-sigs:master Mar 17, 2019
openshift-merge-robot referenced this pull request in openshift/cluster-api-provider-azure Mar 22, 2019
@awesomenix @openshift-merge-robot
Create certificates, admin kubeconfig, bootstrap token and discoveryh…
cde05d6 
…ashes using kubeadm (#136)

* Generate certificates using kubeadm instead of manual operations right now, this consolidates efforts into upstream, any bug fixes, updates are consumed

* Update cluster-api dependency (#133)

Signed-off-by: Stephen Augustus <saugustus@vmware.com>

* Bring vendor into sync

* Bring vendor into sync

* Fix lint issues

* Address review comments

* Move adminkubeconfig and discoverhashes to cluster status instead of clusterspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus left review comments

@detiber detiber detiber left review comments

@tariq1890 tariq1890 tariq1890 left review comments

@juan-lee juan-lee juan-lee left review comments

@apelisse apelisse Awaiting requested review from apelisse

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@chuckha chuckha Awaiting requested review from chuckha

@randomvariable randomvariable Awaiting requested review from randomvariable

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@justaugustus justaugustus

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@awesomenix @k8s-ci-robot @justaugustus @detiber @tariq1890 @juan-lee