Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update upstream k8s CI image store reference #1515

Merged
merged 1 commit into from
Jul 14, 2021
Merged

update upstream k8s CI image store reference #1515

merged 1 commit into from
Jul 14, 2021

Conversation

jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Jul 12, 2021 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This moves changes from #1512 into the release-0.4 branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added this to the v0.4.16 milestone Jul 12, 2021
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider labels Jul 12, 2021
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 12, 2021
@jackfrancis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

@k8s-ci-robot
Copy link
Contributor

@jackfrancis: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-azure-test-release-0-4
  • /test pull-cluster-api-provider-azure-build-release-0-4
  • /test pull-cluster-api-provider-azure-e2e-release-0-4
  • /test pull-cluster-api-provider-azure-e2e-full-release-0-4
  • /test pull-cluster-api-provider-azure-e2e-windows-release-0-4
  • /test pull-cluster-api-provider-azure-capi-e2e-release-0-4
  • /test pull-cluster-api-provider-azure-verify-release-0-4
  • /test pull-cluster-api-provider-azure-conformance-v1alpha3-release-0-4
  • /test pull-cluster-api-provider-azure-conformance-v1alpha3-with-ci-artifacts-release-0-4
  • /test pull-cluster-api-provider-azure-apidiff-release-0-4

Use /test all to run the following jobs:

  • pull-cluster-api-provider-azure-test-release-0-4
  • pull-cluster-api-provider-azure-build-release-0-4
  • pull-cluster-api-provider-azure-e2e-release-0-4
  • pull-cluster-api-provider-azure-e2e-windows-release-0-4
  • pull-cluster-api-provider-azure-verify-release-0-4
  • pull-cluster-api-provider-azure-apidiff-release-0-4

In response to this:

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor

/test pull-cluster-api-provider-azure-conformance-v1alpha3-with-ci-artifacts-release-0-4

@spiffxp
Copy link
Member

spiffxp commented Jul 12, 2021

ref: kubernetes/k8s.io#2318

@jackfrancis
Copy link
Contributor Author

/retest

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@sbueringer
Copy link
Member

/lgtm

@CecileRobertMichon
Copy link
Contributor

@jackfrancis please add a release note or "NONE"

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit b1313d7 into kubernetes-sigs:release-0.4 Jul 14, 2021
@jackfrancis jackfrancis deleted the images-change-for-0.4 branch July 26, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

Assignees

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jackfrancis @k8s-ci-robot @CecileRobertMichon @spiffxp @sbueringer