prefer CAPI replicas-managed-by annotation for AKS autoscaler #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/S
|
/assign @CecileRobertMichon |
jackfrancis
force-pushed
the
replicas-managed-by-capi
branch
from
eb4a88b
to
59a809c
Compare
|
/retest |
1 similar comment
|
/retest |
jackfrancis
force-pushed
the
replicas-managed-by-capi
branch
from
59a809c
to
7a08f2c
Compare
jackfrancis
force-pushed
the
replicas-managed-by-capi
branch
from
7a08f2c
to
b8f29c0
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR changes the annotation that we add to AKS node pools to the CAPI-defined
"cluster.x-k8s.io/replicas-managed-by"annotation.See:
This PR also deprecates the CAPZ-defined
"cluster.x-k8s.io/replicas-managed-by-autoscaler"annotation. We include a fallback support for this during MachinePool reconciliation, to aid forward-compatibility for existing clusters using the previous annotation.I've decided not to worry about cleaning up the legacy annotation: upon the first reconciliation of the AKS node pool, CAPZ will assign the new, CAPI annotation. This seems simpler than worry about checking for existence of the old annotation on each reconcile loop, and deleting it if it's affected. The additional fallback code that supports the legacy annotation is not a maintenance burden, IMO.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2993
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: