-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer CAPI replicas-managed-by annotation for AKS autoscaler #2996
prefer CAPI replicas-managed-by annotation for AKS autoscaler #2996
Conversation
/assign @CecileRobertMichon |
eb4a88b
to
59a809c
Compare
/retest |
1 similar comment
/retest |
59a809c
to
7a08f2c
Compare
7a08f2c
to
b8f29c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
What this PR does / why we need it:
This PR changes the annotation that we add to AKS node pools to the CAPI-defined
"cluster.x-k8s.io/replicas-managed-by"
annotation.See:
This PR also deprecates the CAPZ-defined
"cluster.x-k8s.io/replicas-managed-by-autoscaler"
annotation. We include a fallback support for this during MachinePool reconciliation, to aid forward-compatibility for existing clusters using the previous annotation.I've decided not to worry about cleaning up the legacy annotation: upon the first reconciliation of the AKS node pool, CAPZ will assign the new, CAPI annotation. This seems simpler than worry about checking for existence of the old annotation on each reconcile loop, and deleting it if it's affected. The additional fallback code that supports the legacy annotation is not a maintenance burden, IMO.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2993
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: