-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AzureEnvironment to AzureManagedControlPlane #3509
Conversation
@devigned for eyes on the rewrite of his previous PR functionality |
@mboersma this is the PR we chatted about earlier today. |
i just forgot about the conversions, this is probably done from my perspective when those get checked in |
a63c3a9
to
78fc4d7
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3509 +/- ##
==========================================
+ Coverage 52.59% 52.80% +0.20%
==========================================
Files 182 182
Lines 18174 18222 +48
==========================================
+ Hits 9559 9622 +63
+ Misses 8077 8060 -17
- Partials 538 540 +2
☔ View full report in Codecov by Sentry. |
/assign |
/test pull-cluster-api-provider-azure-e2e |
@nojnhuh any more thoughts on this? |
@luthermonson I'm good to lgtm pending at least one other look at whether or not to default the field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
I shared some questions around defaulting and validations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
I shared some questions around defaulting and validations.
154d3f0
to
b61303d
Compare
/milestone 1.10 |
@CecileRobertMichon: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last few minor comments but otherwise lgtm! Thank you @luthermonson
Looks good to me pending the nits mentioned by Cecile! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aisde from Cecile's comments, LGTM.
everything addressed, let me know if there's anything else I can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: cb5df934440a28173b97d5aa5767f72fcd3580cc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for AzureManagedControlPlane.AzureEnvironment allowing a user to set a string value which translates into the configuration passed into the Azure Client. This functionality already exists in AzureCluster and this PR allows for Managed clusters to take advantage of the same feature.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3489
Special notes for your reviewer:
There was an override done to bypass some vmss caching issues for tests. This setup a region URL which doesn't work in govcloud and I refactored
newAzureManagedMachinePoolService
to accomodate additional ways to skip using regional authorizers based on config.Release note: