add pause handling for AzureCluster controller #3735
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
|
|
||
| // ClusterUpdatePauseChange returns a predicate that returns true for an update event when a cluster's | ||
| // Spec.Paused changes between any two distinct values. | ||
| func ClusterUpdatePauseChange(logger logr.Logger) predicate.Funcs { |
There was a problem hiding this comment.
This is mostly copy-paste from CAPI's ClusterUpdateUnpaused.
| ctx, _, done := tele.StartSpanWithLogger(ctx, "controllers.azureClusterService.Pause") | ||
| defer done() | ||
|
|
||
| for _, service := range s.services { |
There was a problem hiding this comment.
I don't think the order in which services are paused is significant, at least for ASO.
nojnhuh
force-pushed
the
aso-pause-azurecluster
branch
from
dd22f7c
to
339603a
Compare
| @@ -51,3 +56,63 @@ var _ = Describe("AzureClusterReconciler", func() { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| func TestAzureClusterReconcilePaused(t *testing.T) { | |||
There was a problem hiding this comment.
I originally tried to specify this test like the one above with envtest, but the race detector was flagging something in the logging calls whenever two objects were being created, even serially and with a 10s sleep in between. It was easier to rework this test to use a fake client than try to fix the race which seemed unrelated to the rest of these changes. The test itself hasn't lost any fidelity during that rewrite AFAICT.
|
(squash reminder) /hold |
k8s-ci-robot
added
the
do-not-merge/hold
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
+ Coverage 54.05% 54.26% +0.20%
==========================================
Files 186 186
Lines 18833 18898 +65
==========================================
+ Hits 10181 10255 +74
+ Misses 8105 8088 -17
- Partials 547 555 +8
☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7ed89233f583d5db13927c22afa78f31b057ff2f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
nojnhuh
force-pushed
the
aso-pause-azurecluster
branch
from
1c26aa9
to
8db012a
Compare
|
squashed! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces the capability for CAPZ's Azure service interfaces (i.e.
azure/services/*) to define logic to be run in reaction to a CAPZ resource being paused. The primary change is the introduction of a newreconcilePauseat the same level of abstraction asreconcileNormalandreconcileDelete.The currently-identified use case is to set the serviceoperator.azure.com/reconcile-policy annotation to
skipon ASO resources to communicate CAPI's notion of "paused" to ASO's controllers.This change modifies the AzureCluster controller, but all other controllers using the same
azure.ServiceReconcilerpattern will need to modified similarly, at least once they start using ASO.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #3525
Special notes for your reviewer:
This change only partially addresses #3525. Currently,
reconcilePausewill essentially no-op (aside from logging), so this PR is not expected to produce any meaningfully visible changes. Future PRs will implement the logic to add the annotation to ASO resources, handle the impending block-move CAPI annotation, and implement the same pattern for other CAPZ controllers.TODOs:
Release note: