-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate DNS Service IP to be a .10 IP belonging to Service CIDR #3826
validate DNS Service IP to be a .10 IP belonging to Service CIDR #3826
Conversation
cbf86ed
to
6dd02b1
Compare
6dd02b1
to
6078b79
Compare
.10
IP belonging to Service CIDR
.10
IP belonging to Service CIDR- Removed `validateDNSServiceIP()` from the validators because the DNS Service IP validation was being done in `validateManagedClusterNetwork()`. - update `validateManagedClusterNetwork()` to validate if DNS Service IP is a .10 IP - update mockClient.Get to return clusterv1.Cluster with Service CIDR : `192.168.0.0/26` - update amcp_webhook_test with valid DNS Service IPs and mock client for webhook tests
ac4003d
to
05040f2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3826 +/- ##
==========================================
+ Coverage 54.86% 55.00% +0.13%
==========================================
Files 188 188
Lines 19348 19348
==========================================
+ Hits 10615 10642 +27
+ Misses 8151 8116 -35
- Partials 582 590 +8
☔ View full report in Codecov by Sentry. |
/test pull-cluster-api-provider-azure-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: f325954ee37993b0ba6f9cd8d2a7b3a5f21b465f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR should have been cherry-picked. I am not sure why the CI Robot did not cherry pick ? |
@nawazkh you need to add comment the cherry-pick bot commands on the PR for it to cherry-pick, the checkbox in PR description doesn't do anything, it's just a signal to maintainers/reviewers that they should consider it for cherry-pick /cherry-pick release-1.10 |
@CecileRobertMichon: #3826 failed to apply on top of branch "release-1.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Noted. Thanks! |
/cherry-pick release-1.9 |
@nawazkh: #3826 failed to apply on top of branch "release-1.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Merge conflicts in creating both the cherry-picks.. 🤔 Strange. |
^ raised two cherry-pick PRs |
What type of PR is this?
/kind bug
What this PR does / why we need it:
azuremanagedcontrolplane_webhook
to validate DNS Service IP is a.10
IP address.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3824
Special notes for your reviewer:
TODOs:
Release note: