-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] use token input instead of env for codecov #4934
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4934 +/- ##
==========================================
+ Coverage 62.18% 62.19% +0.01%
==========================================
Files 201 201
Lines 16878 16878
==========================================
+ Hits 10495 10497 +2
+ Misses 5593 5591 -2
Partials 790 790 ☔ View full report in Codecov by Sentry. |
Seems like #4935 needs this fix. |
I'm not sure yet that this actually fixes anything, given this message is what I was hoping to avoid:
I think I might try bumping the codecov action version here and see if that at least gets the job to succeed at all. |
I'm thinking my hypothesis is wrong here so I don't think this actually makes any meaningful difference. /close |
@nojnhuh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I have a hypothesis that the recent changes to codecov to use tokens defined in forks to get around the rate limits associated with tokenless uploads requires the
token
input to be set instead of theCODECOV_TOKEN
environment variable.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: