-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add single stack IPv6 support #646
Conversation
Hi @jsturtevant. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
it is now working but currently has issues with route creation #682 |
Update cluster.go Update azurecluster_conversion.go
Co-Authored-By: Anish Ramasekar <10608509+aramase@users.noreply.github.com> comments
40aa38a
to
986f53e
Compare
rebased |
986f53e
to
8f73c74
Compare
/lgtm Great collaboration folks! |
awesome work all, even though we will get probably get merge conflicts now :D /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks like something timed out /test pull-cluster-api-provider-azure-e2e |
8f73c74
to
c05182f
Compare
Had to change the ipv6 template to use |
@jsturtevant: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
What this PR does / why we need it:
Adds ipv6 support. To use, set
CLUSTER_TEMPLATE
tocluster-template-ipv6.yaml
.Co-authored by @jsturtevant, @CecileRobertMichon and @aramase.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #318
Special notes for your reviewer:
Before merging needs:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: