-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💎 refactor most services into Reconcile/Delete pattern #713
💎 refactor most services into Reconcile/Delete pattern #713
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
type azureMachineService struct { | ||
machineScope *scope.MachineScope | ||
clusterScope *scope.ClusterScope | ||
availabilityZonesSvc azure.GetterService | ||
networkInterfacesSvc azure.Service | ||
virtualMachinesSvc azure.GetterService | ||
disksSvc azure.GetterService | ||
virtualMachinesSvc *virtualmachines.Service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is temporary to allow removing use of GetterService. In a follow up, virtualMachinesSvc
will also become an azure.Service
after we remove all Get() calls from the controller (see #110 for more info).
2e930d7
to
962bbc2
Compare
/hold for release |
/hold cancel |
9454f9e
to
e8b666c
Compare
cef8481
to
304e47d
Compare
@CecileRobertMichon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @devigned @nader-ziada @alexeldeib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Always good to see more red than green in a refactor. Definitely looking forward to the refactor containing the IPAddress changes.
/lgtm |
What this PR does / why we need it: Remove the exported
Get()
function from every Service except availability zones, virtual machines, scale sets, and managed clusters (these will be addressed in follow-ups.)In order to keep the size of this PR manageable and facilitate reviews, I tried to scope this refactor down to only Services that did have Get() calls within the controller/reconciler.
**⚠️ Important:** This is NOT the north star. This is closer to the end goal:
https://github.com/CecileRobertMichon/cluster-api-provider-azure/compare/reconcile-delete...CecileRobertMichon:public-ips-scope?expand=1#diff-890b2d661da1708cb3d23d43fc548ceeR28
This PR is just an intermediary step to get there.
Future work:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Partially addresses #110 and #609
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: