Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: Add a make target to generate test coverage report #779

Merged
merged 1 commit into from
Aug 3, 2020
Merged

makefile: Add a make target to generate test coverage report #779

merged 1 commit into from
Aug 3, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 10, 2020

What this PR does / why we need it:
This PR adds a make target to generate test coverage reports in similar way that was added here: kubernetes-sigs/cluster-api#3310

After this, we can create the prow job to generate the reports. i hope :)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes partially #692

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

makefile: Add a make target to generate test coverage report

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Jul 10, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2020
@cpanato
Copy link
Member Author

cpanato commented Jul 10, 2020 •
edited
Loading

/test pull-cluster-api-provider-azure-test

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve
/hold
hold until kubernetes-sigs/cluster-api#3310 merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2020
nader-ziada
nader-ziada reviewed Jul 13, 2020
View reviewed changes
Makefile Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2020
@nader-ziada
Copy link
Contributor

now runs fine, but how are we going to use this? do we need a script or something to calculate the total coverage so we can show that in the PR status?

@cpanato
Copy link
Member Author

cpanato commented Jul 21, 2020

@nader-ziada next step after this is create a new prow job that runs this target and generate the information

@nader-ziada
Copy link
Contributor

lgtm
@CecileRobertMichon do we need to wait for the cluster-api PR to merge first?

@CecileRobertMichon
Copy link
Contributor

@nader-ziada no strict dependency but wanted to try to align with CAPI and there seemed to be some unresolved discussion in kubernetes-sigs/cluster-api#3310

@cpanato
Copy link
Member Author

cpanato commented Aug 2, 2020

@CecileRobertMichon @nader-ziada kubernetes-sigs/cluster-api#3310 is merged, if we merge this I will continue in the work and add the prow jobs

@nader-ziada
Copy link
Contributor

nader-ziada commented Aug 3, 2020 •
edited
Loading

@CecileRobertMichon @nader-ziada kubernetes-sigs/cluster-api#3310 is merged, if we merge this I will continue in the work and add the prow jobs

lgtm

@CecileRobertMichon
Copy link
Contributor

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5684af2 into kubernetes-sigs:master Aug 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4.7 milestone Aug 3, 2020
@cpanato cpanato deleted the GH-692 branch August 3, 2020 18:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nader-ziada nader-ziada nader-ziada left review comments

@awesomenix awesomenix Awaiting requested review from awesomenix

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.7
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @CecileRobertMichon @nader-ziada @k8s-ci-robot