-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make error handling consistent across all packages #104
Comments
Created #109 to make the error handling consistent across the project. Re logging: we use glog currently but there has been discussion about how glog might not be a good choice for logging - kubernetes/kubernetes#61006. Fwiw, with respects to the project moving upstream, Kubernetes itself uses glog right now and it doesn't look like it is going to move away from it soon. |
Are there any updates regarding the logging topic ? It seems that a lot of upstream projects use |
@solidnerd Moving to If you'd like to take on it as well, let us know. I would just recommend waiting for #126 or working based on that branch, as there are some packages that are added and removed. |
@solidnerd Sounds good, thanks! :) |
@xmudrii what is missing here to bring this issue over the line ? |
@solidnerd I think it's okay to close this issue. Thanks for the help! /close |
@xmudrii: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
User story
In #87 the error handling got improved for some packages. We should check other packages and make sure the error checking and handling is consistent across all packages.
We could research is it possible to overall improve logging and error handling. For ideas, we can see how other providers handle this.
Acceptance criteria
The text was updated successfully, but these errors were encountered: