-
Notifications
You must be signed in to change notification settings - Fork 77
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Scale from and to 0 support for autoscaler for VPC cluster (#1523)
* Added support VPC autoscaler * Update controllers/ibmvpcmachinetemplate_controller_test.go Co-authored-by: Prajyot Parab <prajyot.parab2@ibm.com> * Removed duplicate and updated error message --------- Co-authored-by: Prajyot Parab <prajyot.parab2@ibm.com>
- Loading branch information
1 parent
ea18e5b
commit 7150fb8
Showing
14 changed files
with
514 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* | ||
| Copyright 2023 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package controllers | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "reflect" | ||
|
|
||
| "github.com/IBM/vpc-go-sdk/vpcv1" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| "k8s.io/apimachinery/pkg/api/resource" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
|
|
||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| "sigs.k8s.io/cluster-api/util/patch" | ||
|
|
||
| infrav1beta2 "sigs.k8s.io/cluster-api-provider-ibmcloud/api/v1beta2" | ||
| "sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/vpc" | ||
| "sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/endpoints" | ||
| ) | ||
|
|
||
| // IBMVPCMachineTemplateReconciler reconciles a IBMVPCMachineTemplate object. | ||
| type IBMVPCMachineTemplateReconciler struct { | ||
| client.Client | ||
| Scheme *runtime.Scheme | ||
| ServiceEndpoint []endpoints.ServiceEndpoint | ||
| } | ||
|
|
||
| func (r *IBMVPCMachineTemplateReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewControllerManagedBy(mgr). | ||
| For(&infrav1beta2.IBMVPCMachineTemplate{}). | ||
| Complete(r) | ||
| } | ||
|
|
||
| // +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=ibmvpcmachinetemplates,verbs=get;list;watch | ||
| // +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=ibmvpcmachinetemplates/status,verbs=get;update;patch | ||
|
|
||
| func (r *IBMVPCMachineTemplateReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | ||
| log := ctrl.LoggerFrom(ctx) | ||
| log.Info("Reconciling IBMVPCMachineTemplate") | ||
|
|
||
| var machineTemplate infrav1beta2.IBMVPCMachineTemplate | ||
| if err := r.Get(ctx, req.NamespacedName, &machineTemplate); err != nil { | ||
| log.Error(err, "Unable to fetch ibmvpcmachinetemplate") | ||
| return ctrl.Result{}, client.IgnoreNotFound(err) | ||
| } | ||
|
|
||
| region := endpoints.CostructRegionFromZone(machineTemplate.Spec.Template.Spec.Zone) | ||
|
|
||
| // Fetch the service endpoint. | ||
| svcEndpoint := endpoints.FetchVPCEndpoint(region, r.ServiceEndpoint) | ||
|
|
||
| vpcClient, err := vpc.NewService(svcEndpoint) | ||
| if err != nil { | ||
| return ctrl.Result{}, fmt.Errorf("failed to create IBM VPC client: %w", err) | ||
| } | ||
|
|
||
| return r.reconcileNormal(ctx, vpcClient, machineTemplate) | ||
| } | ||
|
|
||
| func (r *IBMVPCMachineTemplateReconciler) reconcileNormal(ctx context.Context, vpcClient vpc.Vpc, machineTemplate infrav1beta2.IBMVPCMachineTemplate) (ctrl.Result, error) { | ||
| log := ctrl.LoggerFrom(ctx) | ||
| helper, err := patch.NewHelper(&machineTemplate, r.Client) | ||
| if err != nil { | ||
| return ctrl.Result{}, fmt.Errorf("failed to init patch helper: %w", err) | ||
| } | ||
|
|
||
| options := &vpcv1.GetInstanceProfileOptions{} | ||
| options.SetName(machineTemplate.Spec.Template.Spec.Profile) | ||
| profileDetails, _, err := vpcClient.GetInstanceProfile(options) | ||
| if err != nil { | ||
| return ctrl.Result{}, fmt.Errorf("failed to fetch profile Details: %w", err) | ||
| } | ||
|
|
||
| if profileDetails == nil { | ||
| return ctrl.Result{}, fmt.Errorf("failed to find profileDetails") | ||
| } | ||
|
|
||
| log.V(3).Info("Profile Details:", "profileDetails", profileDetails) | ||
|
|
||
| capacity := make(corev1.ResourceList) | ||
| memory := fmt.Sprintf("%vG", *profileDetails.Memory.(*vpcv1.InstanceProfileMemory).Value) | ||
| cpu := fmt.Sprintf("%v", *profileDetails.VcpuCount.(*vpcv1.InstanceProfileVcpu).Value) | ||
| capacity[corev1.ResourceCPU] = resource.MustParse(cpu) | ||
| capacity[corev1.ResourceMemory] = resource.MustParse(memory) | ||
|
|
||
| log.V(3).Info("Calculated capacity for machine template", "capacity", capacity) | ||
| if !reflect.DeepEqual(machineTemplate.Status.Capacity, capacity) { | ||
| machineTemplate.Status.Capacity = capacity | ||
| if err := helper.Patch(ctx, &machineTemplate); err != nil { | ||
| if !apierrors.IsNotFound(err) { | ||
| log.Error(err, "Failed to patch machineTemplate") | ||
| return ctrl.Result{}, err | ||
| } | ||
| } | ||
| } | ||
| log.V(3).Info("Machine template status", "status", machineTemplate.Status) | ||
| return ctrl.Result{}, nil | ||
| } |
Oops, something went wrong.