Skip to content

Commit

Permalink
Fix test failures
Browse files Browse the repository at this point in the history
  • Loading branch information
Karthik-K-N committed Feb 28, 2024
1 parent 01de3b4 commit 8fbde63
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
1 change: 0 additions & 1 deletion api/v1beta2/ibmpowervscluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ type IBMPowerVSClusterSpec struct {
// dhcpServer is contains the configuration to be used while creating a new DHCP server in PowerVS workspace.
// when the field is omitted, CLUSTER_NAME will be used as DHCPServer.Name and DHCP server will be created.
// it will automatically create network with name DHCPSERVER<DHCPServer.Name>_Private in PowerVS workspace.
// the default name
// +optional
DHCPServer *DHCPServer `json:"dhcpServer,omitempty"`

Expand Down
4 changes: 2 additions & 2 deletions cloud/scope/powervs_machine.go
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ func (m *PowerVSMachineScope) SetHealth(health *models.PVMInstanceHealth) {
}

// SetAddresses will set the addresses for the machine.
func (m *PowerVSMachineScope) SetAddresses(instance *models.PVMInstance) {
func (m *PowerVSMachineScope) SetAddresses(instance *models.PVMInstance) { //nolint:gocyclo
var addresses []corev1.NodeAddress
// Setting the name of the vm to the InternalDNS and Hostname as the vm uses that as hostname.
addresses = append(addresses, corev1.NodeAddress{
Expand Down Expand Up @@ -910,7 +910,7 @@ func (m *PowerVSMachineScope) GetMachineInternalIP() string {
}

// CreateVPCLoadBalancerPoolMember creates a member in load balaner pool.
func (m *PowerVSMachineScope) CreateVPCLoadBalancerPoolMember() (*vpcv1.LoadBalancerPoolMember, error) {
func (m *PowerVSMachineScope) CreateVPCLoadBalancerPoolMember() (*vpcv1.LoadBalancerPoolMember, error) { //nolint:gocyclo
loadBalancers := make([]infrav1beta2.VPCLoadBalancerSpec, 0)
if len(m.IBMPowerVSCluster.Spec.LoadBalancers) == 0 {
loadBalancer := infrav1beta2.VPCLoadBalancerSpec{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,7 @@ spec:
creating a new DHCP server in PowerVS workspace. when the field
is omitted, CLUSTER_NAME will be used as DHCPServer.Name and DHCP
server will be created. it will automatically create network with
name DHCPSERVER<DHCPServer.Name>_Private in PowerVS workspace. the
default name
name DHCPSERVER<DHCPServer.Name>_Private in PowerVS workspace.
properties:
cidr:
description: Optional cidr for DHCP private network
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ spec:
when the field is omitted, CLUSTER_NAME will be used as
DHCPServer.Name and DHCP server will be created. it will
automatically create network with name DHCPSERVER<DHCPServer.Name>_Private
in PowerVS workspace. the default name
in PowerVS workspace.
properties:
cidr:
description: Optional cidr for DHCP private network
Expand Down

0 comments on commit 8fbde63

Please sign in to comment.