IBMPowerVSmachine controller ignores serviceinstance id

[Karthik-K-N]

/kind bug
/area provider/ibmcloud

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

Example machine spec

apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
kind: IBMPowerVSMachine
metadata:
  creationTimestamp: null
  labels:
    cluster.x-k8s.io/control-plane: ""
  name: rdr-hamzy-test-wdc06-4btmf-master-0
spec:
  imageRef:
    name: rdr-hamzy-test-wdc06-4btmf-image
  memoryGiB: 32
  network: {}
  processorType: Shared
  processors: "0.5"
  serviceInstance:
    id: 984d148e-f7b0-4994-aa27-143753f863ef
  serviceInstanceID: ""
  systemType: s922
status:
  ready: false

Currently code only checks for service instanceid or name

cluster-api-provider-ibmcloud/cloud/scope/powervs_machine.go

Lines 163 to 170 in 3add9b2

	if params.IBMPowerVSMachine.Spec.ServiceInstanceID != "" {
	serviceInstanceID = params.IBMPowerVSMachine.Spec.ServiceInstanceID
	} else {
	serviceInstanceName = fmt.Sprintf("%s-%s", params.IBMPowerVSCluster.GetName(), "serviceInstance")
	if params.IBMPowerVSCluster.Spec.ServiceInstance != nil && params.IBMPowerVSCluster.Spec.ServiceInstance.Name != nil {
	serviceInstanceName = *params.IBMPowerVSCluster.Spec.ServiceInstance.Name
	}
	}

its leading to machine reconcilation error

E0307 15:02:44.774996 4044579 controller.go:329]  "msg"="Reconciler error" "error"="failed to create scope: service instance rdr-hamzy-test-wdc06-vjnpj-serviceInstance is not yet created" 

What did you expect to happen:

Support checking for service instance id.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster-api version:
• Minikube/KIND version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[Karthik-K-N]

/close

[k8s-ci-robot]

@Karthik-K-N: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.