Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Ginkgo from v1 to v2 #751

Closed
mkumatag opened this issue Jul 13, 2022 · 8 comments
Closed

Migrate Ginkgo from v1 to v2 #751

mkumatag opened this issue Jul 13, 2022 · 8 comments
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@mkumatag
Copy link
Member

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
As Ginkgo v1 is deprecated and seen this following deprecated notice in our most of the e2e test reports, so we need to migrate to v2 version

�[38;5;228mYou're using deprecated Ginkgo functionality:�[0m
�[38;5;228m=============================================�[0m
�[1m�[38;5;10mGinkgo 2.0�[0m is under active development and will introduce several new features, improvements, and a small handful of breaking changes.
A release candidate for 2.0 is now available and 2.0 should GA in Fall 2021.  �[1mPlease give the RC a try and send us feedback!�[0m
  - To learn more, view the migration guide at �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md�[0m
  - For instructions on using the Release Candidate visit �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#using-the-beta�[0m
  - To comment, chime in at �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/issues/711�[0m

  �[38;5;11mYou are using a custom reporter.  Support for custom reporters will likely be removed in V2.  Most users were using them to generate junit or teamcity reports and this functionality will be merged into the core reporter.  In addition, Ginkgo 2.0 will support emitting a JSON-formatted report that users can then manipulate to generate custom reports.

  �[38;5;9m�[1mIf this change will be impactful to you please leave a comment on �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/issues/711�[0m�[0m
  �[1mLearn more at:�[0m �[38;5;14m�[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#removed-custom-reporters�[0m

�[38;5;243mTo silence deprecations that can be silenced set the following environment variable:�[0m
  �[38;5;243mACK_GINKGO_DEPRECATIONS=1.16.5�[0m

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jul 13, 2022
@mkumatag mkumatag added this to the 0.3 milestone Jul 13, 2022
@mkumatag
Copy link
Member Author

@Amulyam24 @Prajyot-Parab see if anyone of you are interested picking this one.

@mkumatag
Copy link
Member Author

For reference - kubernetes/kubernetes#109111

@mkumatag
Copy link
Member Author

CAPI PR: kubernetes-sigs/cluster-api#6906

@Amulyam24
Copy link
Contributor

I'll work on it 👍🏼
/assign

@Amulyam24
Copy link
Contributor

  • The CAPI project has decided to hold off the bump to Ginkgo v2 till the release 1.3.0(ref- PR above and https://kubernetes.slack.com/archives/C8TSNPY4T/p1657801887174059).
    Dependency- The provider E2E test framework is based on the CAPI E2E framework.
  • Another dependency is the controller-runtime module that depends on ginkgo v1 and leads to indirect importing of it which could cause conflict in handling the flags

@mkumatag mkumatag modified the milestones: 0.3, Next Aug 25, 2022
@mkumatag mkumatag modified the milestones: Next, 0.4.0 Sep 2, 2022
@Prajyot-Parab
Copy link
Contributor

@Amulyam24 are we good to close this one?

@Amulyam24
Copy link
Contributor

Yes, this can be closed.
/close

@k8s-ci-robot
Copy link
Contributor

@Amulyam24: Closing this issue.

In response to this:

Yes, this can be closed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants