-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targets for verifying code and images for vulnerabilities #1422
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@@ -18,6 +18,8 @@ ROOT_DIR_RELATIVE := . | |||
|
|||
include $(ROOT_DIR_RELATIVE)/common.mk | |||
|
|||
GO_VERSION ?= 1.20.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be a follow up PR required for maintaining the golang version in one place and use it everywhere including dockerfiles, makefile and GitHub action
@@ -544,6 +569,10 @@ clean-temporary: ## Remove all temporary files and folders | |||
clean-release: ## Remove the release folder | |||
rm -rf $(RELEASE_DIR) | |||
|
|||
.PHONY: clean-release-git | |||
clean-release-git: ## Restores the git files usually modified during a release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are we calling this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 33 of file - verify-container-images.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: