Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api specs #1592

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Update api specs #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1beta1/zz_generated.conversion.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/v1beta2/ibmpowervscluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ type IBMPowerVSClusterStatus struct {
// transitGateway is reference to IBM Cloud TransitGateway.
TransitGateway *ResourceReference `json:"transitGateway,omitempty"`

// cosBucket is reference to IBM Cloud COS Bucket resource.
COSBucket *ResourceReference `json:"cosBucket,omitempty"`
// cosInstance is reference to IBM Cloud COS Instance resource.
COSInstance *ResourceReference `json:"cosInstance,omitempty"`

// loadBalancers reference to IBM Cloud VPC Loadbalancer.
LoadBalancers map[string]VPCLoadBalancerStatus `json:"loadBalancers,omitempty"`
Expand Down
5 changes: 3 additions & 2 deletions api/v1beta2/ibmvpccluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,14 @@ type VPCLoadBalancerStatus struct {
// id of VPC load balancer.
// +optional
ID *string `json:"id,omitempty"`
// +optional
Name *string `json:"name,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I thought of having Loadbalaners in status as slice so name was required to identify a loadbalancer, During our api review we decided to have map instead of list hence the name is no more required.

// State is the status of the load balancer.
State VPCLoadBalancerState `json:"state,omitempty"`
// hostname is the hostname of load balancer.
// +optional
Hostname *string `json:"hostname,omitempty"`
// +kubebuilder:default=false
// controllerCreated indicates whether the resource is created by the controller.
ControllerCreated *bool `json:"controllerCreated,omitempty"`
}

// IBMVPCClusterStatus defines the observed state of IBMVPCCluster.
Expand Down
14 changes: 7 additions & 7 deletions api/v1beta2/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_ibmpowervsclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,8 @@ spec:
- type
type: object
type: array
cosBucket:
description: cosBucket is reference to IBM Cloud COS Bucket resource.
cosInstance:
description: cosInstance is reference to IBM Cloud COS Instance resource.
properties:
controllerCreated:
default: false
Expand All @@ -428,14 +428,17 @@ spec:
additionalProperties:
description: VPCLoadBalancerStatus defines the status VPC load balancer.
properties:
controllerCreated:
default: false
description: controllerCreated indicates whether the resource
is created by the controller.
type: boolean
hostname:
description: hostname is the hostname of load balancer.
type: string
id:
description: id of VPC load balancer.
type: string
name:
type: string
state:
description: State is the status of the load balancer.
type: string
Expand Down