Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate DHCP network id #1714

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Validate DHCP network id #1714

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
232e33b
Revert "Use uncached client (#1682)"
Karthik-K-N Mar 27, 2024
e29fc8f
Explicitly set GVK for IBMPowerVSCluster object
Karthik-K-N Mar 27, 2024
1ace620
Validate Network ID for nil before dereferencing
Karthik-K-N Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions cloud/scope/powervs_machine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,10 @@ func (m *PowerVSMachineScope) SetAddresses(instance *models.PVMInstance) { //nol
// Get the Details of DHCP server associated with the network
var dhcpServerDetails *models.DHCPServerDetail
for _, server := range dhcpServer {
if server.Network == nil || server.Network.ID == nil {
m.V(3).Info("Skipping the DHCP server as its network details is nil", "DHCP server", *server.ID)
continue
}
if *server.Network.ID == *networkID {
m.Info("found DHCP server for network", "DHCP server ID", *server.ID, "network ID", *networkID)
dhcpServerDetails, err = m.IBMPowerVSClient.GetDHCPServer(*server.ID)
Expand Down