Update PortRange and ICMP types for Security Groups

[cjschaef]

Update the types for PortRange fields and for ICMP fields in the Security Groups, to make setting and checking easier.

What this PR does / why we need it: Convert certain fields to types more in line with API fields.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Converted PortRange and ICMP fields for Security Group Rules to be more in line with API

[k8s-ci-robot]

Hi @cjschaef. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	6bd70c0
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/663119b8717511000861357b
😎 Deploy Preview	https://deploy-preview-1752--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Karthik-K-N]

@dharaneeshvrd Please take a look. Thanks

[mkumatag]

/ok-to-test

[dharaneeshvrd]

Changes looks good!
@cjschaef I just have a comment on VPC and ResourceGroup properties of type SecurityGroup. are you planning to pass a different VPC and Resource Group than the one cluster is using? Just wanted to understand what is the intention for the properties?

[mkumatag]

@cjschaef I just have a comment on VPC and ResourceGroup properties of type SecurityGroup. are you planning to pass a different VPC and Resource Group than the one cluster is using? Just wanted to understand what is the intention for the properties?

@dharaneeshvrd can you create an issue for this one and tag @cjschaef if its not related to this PR?

[mkumatag]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjschaef, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dharaneeshvrd]

@cjschaef I just have a comment on VPC and ResourceGroup properties of type SecurityGroup. are you planning to pass a different VPC and Resource Group than the one cluster is using? Just wanted to understand what is the intention for the properties?

@dharaneeshvrd can you create an issue for this one and tag @cjschaef if its not related to this PR?

Sure, since he is making changes to the API spec anyway, thought we can change or remove these properties too if its not required.
We can handle it later too.

[mkumatag]

@cjschaef I just have a comment on VPC and ResourceGroup properties of type SecurityGroup. are you planning to pass a different VPC and Resource Group than the one cluster is using? Just wanted to understand what is the intention for the properties?

@dharaneeshvrd can you create an issue for this one and tag @cjschaef if its not related to this PR?

Sure, since he is making changes to the API spec anyway, thought we can change or remove these properties too if its not required. We can handle it later too.

we need to address in this release itself :)