Rename VPC security group types #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/ibmcloud
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Amulyam24
reviewed
May 20, 2024
| // id of the Security Group. | ||
| // +optional | ||
| ID *string `json:"id,omitempty"` | ||
|
|
||
| // name of the Security Group. | ||
| // +optional | ||
| Name *string `json:"name,omitempty"` |
There was a problem hiding this comment.
@dharaneeshvrd, is this by mistake? you intended to delete VPC and ResouceGroup right
There was a problem hiding this comment.
Yes, corrected, thanks @Amulyam24 !
dharaneeshvrd
force-pushed
the
refactor-vpc-sg-types
branch
2 times, most recently
from
7815402
to
e714b4f
Compare
Amulyam24
approved these changes
May 20, 2024
k8s-ci-robot
added
the
lgtm
mkumatag
requested changes
May 20, 2024
api/v1beta2/types.go
Outdated
|
|
||
| const ( | ||
| // SecurityGroupRuleActionAllow defines that the Rule should allow traffic. | ||
| SecurityGroupRuleActionAllow SecurityGroupRuleAction = vpcv1.NetworkACLRuleActionAllowConst | ||
| SecurityGroupRuleActionAllow VPCSecurityGroupRuleAction = vpcv1.NetworkACLRuleActionAllowConst |
There was a problem hiding this comment.
Do you wanna rename the variable names as well to keep them also in the same format?
There was a problem hiding this comment.
Yes renamed all of them, thanks!
dharaneeshvrd
force-pushed
the
refactor-vpc-sg-types
branch
from
e714b4f
to
8e1b2c2
Compare
k8s-ci-robot
removed
the
lgtm
Remove VPC and resource group field from VPC security group since it is causing confusion by providing an option to pass a different resource than the one used in cluster
dharaneeshvrd
force-pushed
the
refactor-vpc-sg-types
branch
from
8e1b2c2
to
5133465
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, dharaneeshvrd, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove VPC and resource group field from VPC security group since it is causing by providing an option to pass a different resource than the one used in cluster
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1770
Special notes for your reviewer:
/area provider/ibmcloud
Release note: