Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip load balancer pool member deletion if instance creation fails #1785

Merged
merged 1 commit into from
May 21, 2024
Merged

skip load balancer pool member deletion if instance creation fails #1785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions cloud/scope/machine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,11 @@ func (m *MachineScope) CreateVPCLoadBalancerPoolMember(internalIP *string, targe

// DeleteVPCLoadBalancerPoolMember deletes a pool member from the load balancer pool.
func (m *MachineScope) DeleteVPCLoadBalancerPoolMember() error {
if m.IBMVPCMachine.Status.InstanceID == "" {
m.Info("instance is not created, ignore deleting load balancer pool member")
return nil
}

loadBalancer, _, err := m.IBMVPCClient.GetLoadBalancer(&vpcv1.GetLoadBalancerOptions{
ID: m.IBMVPCCluster.Status.VPCEndpoint.LBID,
})
Expand Down