Use the COS endpoint override when generating bootstrap ignition #1860

mjturek · 2024-06-27T23:48:01Z

What this PR does / why we need it: When overridding the COS endpoint in the disconnected use case, we'll need to also grab ignition from the same endpoint. This PR uses the COS endpoint override when generating the ignition config for the bootstrap machine.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

linux-foundation-easycla · 2024-06-27T23:48:04Z

The committers listed above are authorized under a signed CLA.

✅ login: mjturek / name: Mike Turek (560153e)

k8s-ci-robot · 2024-06-27T23:48:09Z

Welcome @mjturek!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-06-27T23:48:10Z

Hi @mjturek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-06-27T23:48:18Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`560153e`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66841e5cfc24f0000846c180
😎 Deploy Preview	https://deploy-preview-1860--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mjturek · 2024-06-27T23:52:25Z

@Karthik-K-N @Prajyot-Parab please let me know what you think of this

Karthik-K-N

I didn't get a chance to test this, I hope you have done it.
Overall it LGTM.
Thank you for the PR

Karthik-K-N · 2024-07-01T05:33:53Z

cloud/scope/powervs_machine.go

+
+	cosServiceEndpoint := endpoints.FetchEndpoints(string(endpoints.COS), m.ServiceEndpoint)
+	if cosServiceEndpoint != "" {
+		m.Logger.V(3).Info("Overriding the default COS endpoint in bootstrap ignition", "cosEndpoint", cosServiceEndpoint)


In general it may not be only for bootstrap ignition URL, How about this

Suggested change

m.Logger.V(3).Info("Overriding the default COS endpoint in bootstrap ignition", "cosEndpoint", cosServiceEndpoint)

m.Logger.V(3).Info("Overriding the default COS endpoint in ignition URL", "cosEndpoint", cosServiceEndpoint)

mkumatag · 2024-07-02T13:33:57Z

@mjturek please sign the CLA by following the steps mentioned here - https://github.ibm.com/powercloud/container-dev/blob/master/squad-upstream-core.md#get-access-to-the-k8s-cla

mkumatag · 2024-07-02T13:34:11Z

/ok-to-test

When overridding the COS endpoint in the disconnected use case, we'll need to also grab ignition from the same endpoint.

mjturek · 2024-07-02T16:30:14Z

unfortunately Jeff is out this week so might not get CLA complete until next week

mjturek · 2024-07-12T19:31:46Z

@mkumatag CLA is complete

mkumatag

/lgtm

k8s-ci-robot · 2024-07-12T20:05:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjturek, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jun 27, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 27, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2024

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024

k8s-ci-robot requested review from Amulyam24 and Prajyot-Parab June 27, 2024 23:48

Karthik-K-N reviewed Jul 1, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2024

Use the COS endpoint override when generating bootstrap ignition

560153e

When overridding the COS endpoint in the disconnected use case, we'll need to also grab ignition from the same endpoint.

mjturek force-pushed the override-ign-cos-endpoint branch from f9c2d92 to 560153e Compare July 2, 2024 15:35

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 12, 2024

mkumatag approved these changes Jul 12, 2024

View reviewed changes

k8s-ci-robot assigned mkumatag Jul 12, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024

k8s-ci-robot merged commit af008bd into kubernetes-sigs:main Jul 12, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the COS endpoint override when generating bootstrap ignition #1860

Use the COS endpoint override when generating bootstrap ignition #1860

mjturek commented Jun 27, 2024

linux-foundation-easycla bot commented Jun 27, 2024 •

edited

Loading

k8s-ci-robot commented Jun 27, 2024

k8s-ci-robot commented Jun 27, 2024

netlify bot commented Jun 27, 2024 •

edited

Loading

mjturek commented Jun 27, 2024

Karthik-K-N left a comment

Karthik-K-N Jul 1, 2024

mjturek Jul 2, 2024

mkumatag commented Jul 2, 2024

mkumatag commented Jul 2, 2024

mjturek commented Jul 2, 2024

mjturek commented Jul 12, 2024

mkumatag left a comment

k8s-ci-robot commented Jul 12, 2024

	m.Logger.V(3).Info("Overriding the default COS endpoint in bootstrap ignition", "cosEndpoint", cosServiceEndpoint)
	m.Logger.V(3).Info("Overriding the default COS endpoint in ignition URL", "cosEndpoint", cosServiceEndpoint)

Use the COS endpoint override when generating bootstrap ignition #1860

Use the COS endpoint override when generating bootstrap ignition #1860

Conversation

mjturek commented Jun 27, 2024

linux-foundation-easycla bot commented Jun 27, 2024 • edited Loading

k8s-ci-robot commented Jun 27, 2024

k8s-ci-robot commented Jun 27, 2024

netlify bot commented Jun 27, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

mjturek commented Jun 27, 2024

Karthik-K-N left a comment

Choose a reason for hiding this comment

Karthik-K-N Jul 1, 2024

Choose a reason for hiding this comment

mjturek Jul 2, 2024

Choose a reason for hiding this comment

mkumatag commented Jul 2, 2024

mkumatag commented Jul 2, 2024

mjturek commented Jul 2, 2024

mjturek commented Jul 12, 2024

mkumatag left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 12, 2024

linux-foundation-easycla bot commented Jun 27, 2024 •

edited

Loading

netlify bot commented Jun 27, 2024 •

edited

Loading