-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPC: Extend VPC API's to support v2 Infra #1875
Conversation
Hi @cjschaef. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
api/v1beta2/ibmvpccluster_types.go
Outdated
|
||
// networkSpec represents the VPC network to use for the cluster. | ||
// +optional | ||
NetworkSpec *VPCNetworkSpec `json:"networkSpec,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NetworkSpec *VPCNetworkSpec `json:"networkSpec,omitempty"` | |
NetworkSpec *VPCNetworkSpec `json:"network,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
api/v1beta2/ibmvpccluster_types.go
Outdated
type VPCNetworkSpec struct { | ||
// computeSubnetsSpec is a set of Subnet's which define the Compute subnets. | ||
// +optional | ||
ComputeSubnetsSpec []Subnet `json:"computeSubnetsSpec,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is for workers, can it be more specific like workerSubnet or something more meaningful, because every node is a compute in the cluster and please remove the Spec
from the end from all the fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
api/v1beta2/ibmvpccluster_types.go
Outdated
|
||
// controlPlaneSubnetsSpec is a set of Subnet's which define the Control Plane subnets. | ||
// +optional | ||
ControlPlaneSubnetsSpec []Subnet `json:"controlPlaneSubentsSpec,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any specific reason for having different subnet for the controlplane and worker nodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the alternative is adding a field to the Subnet to be worker versus control plane. I think it is easier to handle with separate lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the typo..
api/v1beta2/ibmvpccluster_types.go
Outdated
|
||
// controlPlaneSubnets is a set of Subnet's which define the Control Plane subnets. | ||
// +optional | ||
ControlPlaneSubnets []Subnet `json:"controlPlaneSubents,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here!
ControlPlaneSubnets []Subnet `json:"controlPlaneSubents,omitempty"` | |
ControlPlaneSubnets []Subnet `json:"controlPlaneSubnets,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Extend the VPC API's to allow for quick support of the v2 (extended) Infrastructure management code path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjschaef, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Extend the VPC API's to allow for quick support of the v2 (extended) Infrastructure management code path.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: Split off API changes from #1858, will rebase that PR (dropping API changes) once this merges.
/area provider/ibmcloud
Release note: