VPC: Extend VPC API's to support v2 Infra #1875
Conversation
k8s-ci-robot
added
the
area/provider/ibmcloud
k8s-ci-robot
added
cncf-cla: yes
|
Hi @cjschaef. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
api/v1beta2/ibmvpccluster_types.go
Outdated
|
|
||
| // networkSpec represents the VPC network to use for the cluster. | ||
| // +optional | ||
| NetworkSpec *VPCNetworkSpec `json:"networkSpec,omitempty"` |
There was a problem hiding this comment.
| NetworkSpec *VPCNetworkSpec `json:"networkSpec,omitempty"` | |
| NetworkSpec *VPCNetworkSpec `json:"network,omitempty"` |
api/v1beta2/ibmvpccluster_types.go
Outdated
| type VPCNetworkSpec struct { | ||
| // computeSubnetsSpec is a set of Subnet's which define the Compute subnets. | ||
| // +optional | ||
| ComputeSubnetsSpec []Subnet `json:"computeSubnetsSpec,omitempty"` |
There was a problem hiding this comment.
if it is for workers, can it be more specific like workerSubnet or something more meaningful, because every node is a compute in the cluster and please remove the Spec from the end from all the fields
api/v1beta2/ibmvpccluster_types.go
Outdated
|
|
||
| // controlPlaneSubnetsSpec is a set of Subnet's which define the Control Plane subnets. | ||
| // +optional | ||
| ControlPlaneSubnetsSpec []Subnet `json:"controlPlaneSubentsSpec,omitempty"` |
There was a problem hiding this comment.
any specific reason for having different subnet for the controlplane and worker nodes?
There was a problem hiding this comment.
Yes, the alternative is adding a field to the Subnet to be worker versus control plane. I think it is easier to handle with separate lists.
k8s-ci-robot
removed
the
lgtm
api/v1beta2/ibmvpccluster_types.go
Outdated
|
|
||
| // controlPlaneSubnets is a set of Subnet's which define the Control Plane subnets. | ||
| // +optional | ||
| ControlPlaneSubnets []Subnet `json:"controlPlaneSubents,omitempty"` |
There was a problem hiding this comment.
typo here!
| ControlPlaneSubnets []Subnet `json:"controlPlaneSubents,omitempty"` | |
| ControlPlaneSubnets []Subnet `json:"controlPlaneSubnets,omitempty"` |
Extend the VPC API's to allow for quick support of the v2 (extended) Infrastructure management code path.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjschaef, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Extend the VPC API's to allow for quick support of the v2 (extended) Infrastructure management code path.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: Split off API changes from #1858, will rebase that PR (dropping API changes) once this merges.
/area provider/ibmcloud
Release note: