Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add externally managed annotations to IBMPowerVSCluster resource #899

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

Karthik-K-N
Copy link
Contributor

What this PR does / why we need it:

This PR adds the filter to IBMPowerVSCluster reosurce to avoid reconciliation if the resource has the externally managed annotation(cluster.x-k8s.io/managed-by) set.
Enhancement: https://github.com/kubernetes-sigs/cluster-api/blob/10d89ceca938e4d3d94a1d1c2b60515bcdf39829/docs/proposals/20210203-externally-managed-cluster-infrastructure.md

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2022
@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 5cce184
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6332b6a9bc86af000917dbc0
😎 Deploy Preview https://deploy-preview-899--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2022
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@mkumatag
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@mkumatag
Copy link
Member

mkumatag commented Sep 30, 2022

@Prajyot-Parab @Karthik-K-N @dharaneeshvrd can we make sure IBMPowerVSImage delete flow works fine with this flow?

Especially with hypershift project.

@Karthik-K-N
Copy link
Contributor Author

@Prajyot-Parab @Karthik-K-N @dharaneeshvrd can we make sure IBMPowerVSImage delete flow works fine with this flow?

Especially with hypershift project.

I think it should not affect any other things as we adding externally managed annotations only to IBMPowerVSCluster resource and within that recoincilation we are not doing anything other than setting ready status to true.

@mkumatag
Copy link
Member

@Prajyot-Parab @Karthik-K-N @dharaneeshvrd can we make sure IBMPowerVSImage delete flow works fine with this flow?
Especially with hypershift project.

I think it should not affect any other things as we adding externally managed annotations only to IBMPowerVSCluster resource and within that recoincilation we are not doing anything other than setting ready status to true.

I'm have concern about the delete flow because we are deleting them when delete cluster triggered.

@dharaneeshvrd
Copy link
Contributor

@mkumatag As you expected, in hypershift delete flow ibmpowervsimage did nt get deleted, due to that whole deletion got stuck(hosted control plane namespace and due to that hosted cluster).

fyi @Karthik-K-N @Prajyot-Parab

@Karthik-K-N
Copy link
Contributor Author

/hold

@mkumatag
Copy link
Member

mkumatag commented Nov 3, 2022

@Karthik-K-N #938 is merged, hence can this be merged as well?

@Karthik-K-N
Copy link
Contributor Author

@Karthik-K-N #938 is merged, hence can this be merged as well?

Yes.

@mkumatag
Copy link
Member

mkumatag commented Nov 3, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit dead0b1 into kubernetes-sigs:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants