Fix "should succeed with the kubevirt cluster being deleted" unit test #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this unit test is broken. This PR fixes it by populating the `KubevirtClusterReconciler.APIReader` field in unit-test, for mocking. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
`make generate-kccm-flavors` generates wrong manifests, setting a constant names where we should use variables. This commit fixes the `hack/kccm-flavor-gen.sh` script so it will replace the hard coded names with the right variables. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
qinqon
suggested changes
Aug 21, 2023
|
|
||
|
|
||
| sed -i \ | ||
| -E "s|(namespace: )kvcluster|\1\${NAMESPACE}|g;s|(^.*cluster-name=)kvcluster|\1\${CLUSTER_NAME}|g" \ |
There was a problem hiding this comment.
Do you know if we can parameterize it at cloud-provider-kubevirt with something like https://github.com/cert-manager/cert-manager/blob/f970eca76265ff22c868dab3699cdd3cae26e90f/deploy/charts/cert-manager/templates/webhook-deployment.yaml#L68-L69
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This unit test is broken. This PR fixes it by populating the
KubevirtClusterReconciler.APIReaderfield in unit-test, for mocking.In addition, this PR also fixes the
hack/kccm-flavor-gen.shscript so it willreplace the hard coded names with the right variables.
Which issue this PR fixes
fixes #258
Release notes: