Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s deps and golang #287

Merged
merged 8 commits into from
May 30, 2024
Merged

Bump k8s deps and golang #287

merged 8 commits into from
May 30, 2024

Conversation

nunnatsa
Copy link
Contributor

@nunnatsa nunnatsa commented May 30, 2024 •
edited
Loading

Bump dependencies - continue #283

Release notes:

Bump dependencies
Bump golang to 1.22

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from justinsb and qinqon May 30, 2024 13:30
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 30, 2024
This was referenced May 30, 2024
Closed
Closed
@nunnatsa
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 30, 2024
@coveralls
Copy link

coveralls commented May 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9304157913

Details

  • 10 of 18 (55.56%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.1%) to 59.288%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/kubevirtcluster_controller.go 9 17 52.94%
Totals Coverage Status
Change from base Build 9300980468: -4.1%
Covered Lines: 1548
Relevant Lines: 2611
💛 - Coveralls

davidvossel
davidvossel approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [davidvossel,nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e4e898c into kubernetes-sigs:main May 30, 2024
12 checks passed
@nunnatsa nunnatsa deleted the bump-k8s-deps branch May 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@qinqon qinqon Awaiting requested review from qinqon

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nunnatsa @coveralls @k8s-ci-robot @davidvossel @changjjjjjjj