Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Ginkgo v2 during cluster-api v1.3 bump #1315

Closed
tobiasgiese opened this issue Jul 30, 2022 · 2 comments · Fixed by #1406
Closed

Migrate to Ginkgo v2 during cluster-api v1.3 bump #1315

tobiasgiese opened this issue Jul 30, 2022 · 2 comments · Fixed by #1406
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tobiasgiese
Copy link
Member

/kind feature

Describe the solution you'd like

Starting from CAPI v1.3, Ginkgo v2 will be used (kubernetes-sigs/cluster-api#6906).
For bumping to CAPI 1.3 version, we should also migrate e2e tests to v2.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 30, 2022
@oscr
Copy link
Contributor

oscr commented Sep 14, 2022

Just to be clear: does it have to wait for the unreleased cluster-api 1.3 bump or can it be done now?

@seanschneeweiss
Copy link
Contributor

seanschneeweiss commented Sep 25, 2022 •
edited

It was tried to upgrade to Ginkgo with CAPI v1.2 but due to dependencies this seems to be impossible:
kubernetes-sigs/cluster-api-provider-azure#2466

@tobiasgiese tobiasgiese mentioned this issue Dec 3, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Bump CAPI to v1.3.0 mercedes-benz/cluster-api-provider-openstack
4 participants
@oscr @seanschneeweiss @k8s-ci-robot @tobiasgiese