-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update to Ginkgo v2 #2466
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle [WIP] Update to Ginkgo v2 |
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k/k migrated to v2 so that may be a forcing function kubernetes/kubernetes#109111 |
I made a PR to update to Ginkgo v2 in CAPI here: kubernetes-sigs/cluster-api#6906. When that merges in a release, we can revisit and rebase this. |
/close See #2486. I'll resurrect the other changes here once kubernetes-sigs/cluster-api#6906 has merged. |
What type of PR is this?:
/kind cleanup
What this PR does / why we need it:
Updates the Ginkgo test framework to v2 in CAPZ e2e tests.
This is mostly for discussion and learning. This change shouldn't merge until CAPI and other dependencies are also using Ginkgo v2, since the indirect import of v1 will conflict. I used an import hack to work around this for now.
CAPZ has been abusing nested container nodes. This is now an error in Ginkgo v2, so we might consider getting out ahead of that by extracting those
Context
->By
changes into a separate PR.This is a minimal refactoring, but there are more idiomatic changes such as Spec Labels that we might also consider.
Which issue(s) this PR fixes:
Refs kubernetes-sigs/cluster-api#4897
Special notes for your reviewer:
TODOs:
Release note: