Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to Ginkgo v2 #2466

Closed
wants to merge 2 commits into from
Closed

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Jul 8, 2022

What type of PR is this?:

/kind cleanup

What this PR does / why we need it:

Updates the Ginkgo test framework to v2 in CAPZ e2e tests.

This is mostly for discussion and learning. This change shouldn't merge until CAPI and other dependencies are also using Ginkgo v2, since the indirect import of v1 will conflict. I used an import hack to work around this for now.

CAPZ has been abusing nested container nodes. This is now an error in Ginkgo v2, so we might consider getting out ahead of that by extracting those Context -> By changes into a separate PR.

This is a minimal refactoring, but there are more idiomatic changes such as Spec Labels that we might also consider.

Which issue(s) this PR fixes:

Refs kubernetes-sigs/cluster-api#4897

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update to Ginkgo v2

@mboersma mboersma requested a review from sonasingh46 July 8, 2022 22:19
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from mboersma after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma
Copy link
Contributor Author

mboersma commented Jul 8, 2022

/retitle [WIP] Update to Ginkgo v2

@k8s-ci-robot k8s-ci-robot changed the title Update to Ginkgo v2 [WIP] Update to Ginkgo v2 Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2022

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-ci-entrypoint 1921935 link true /test pull-cluster-api-provider-azure-ci-entrypoint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Contributor

k/k migrated to v2 so that may be a forcing function kubernetes/kubernetes#109111

@mboersma
Copy link
Contributor Author

I made a PR to update to Ginkgo v2 in CAPI here: kubernetes-sigs/cluster-api#6906. When that merges in a release, we can revisit and rebase this.

@mboersma mboersma mentioned this pull request Jul 19, 2022
3 tasks
@mboersma
Copy link
Contributor Author

/close

See #2486. I'll resurrect the other changes here once kubernetes-sigs/cluster-api#6906 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants