Update e2e tests for Ginkgo v2 #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @CecileRobertMichon @Jont828 |
|
Does this not need the CAPI version of these changes to merge first? |
No, these are just future-proofing changes that work with either v1 or v2 of Ginkgo. Also we are using |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fixes CAPZ's misuse of Ginkgo container nodes and updates a
ParallelNodesreference such that both will work when we move to Ginkgo v2.Nesting a
Contextinside anItcontainer node is a warning in Ginkgo v1 but an error in v2. We can fix this now for correctness, to simplify the transition to v2, and to prevent more copy-and-pasting of this mistake.Which issue(s) this PR fixes:
Refs #2466
Special notes for your reviewer:
TODOs:
Release note: