-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replatform e2e on to ginkgo v2 #4897
Comments
@randomvariable: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md if people wanna read up |
This looks interesting. But from the messages of robot, some confirmation from maintainers is neccessary. |
/milestone Next |
We should consider also https://github.com/kubernetes-sigs/e2e-framework/ |
I found the following in the e2e logs today and came here to file an issue but looks like this will cover it 👍
|
I have spare some time to investigate the e2e-framework. Its functionality is very similar to what ginkgo/omega provides. I would like to hear more from you guys. |
I'm +1 for investigating the e2e-framework, because AFAIK this is where Kuberenetes is going (cc @vladimirvivien), but this should be discussed in the office hours given that many providers are using the CAPI E2E test in its current form |
Should we separate ginkgo v2 upgrade from exploring the k8s e2e framework? |
This is a possible way forward, but as far as I understand it won't fix #2955 (even if it will mitigate the problems that we have today for cleanup in case of errors) |
Of course I am biased, but I think e2e-framework can help here. (cc @ShwethaKumbla ) |
@vincepri and @fabriziopandini |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale Keeping this open if it's still relevant. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale Keeping this alive as upcoming release of e2e-framework will have features to make it easy to support testing of CRD developments including CAPI. |
/triage accepted As discussed in the CAPI office hours meeting, @mboersma will send an email to the list announcing the timeline for switching to Ginkgo v2. |
User Story
As a developer, I want my infrastructure cleaned up properly after an aborted test run.
Detailed Description
Looks like Ginkgo v2 will solve a lot of problems when it comes to testing on actual infrastructure. One of the main benefits is that
AfterEach
will be executed when tests are aborted, whereas for now onlyAfterSuite
is. In AWS, with the current behaviour, this leaves a lot of resources behind when consuming the CAPI test framework, because we don't know the namespace the framework has created which we normally store in a node-level map for the AfterSuite to iterate through and clean up clusters.As replatforming onto v2 (which isn't released yet) will be a breaking change, very much a v0.5.0 thing.
/milestone next
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
/kind feature
/area testing
/priority important-longterm
The text was updated successfully, but these errors were encountered: